IMPORTANT:
This patch is directly related to and interdependent on a related patch to provision module:
#697954: user 1 name is hardcoded. allow provisioners to specify name for admin user.
You must install both!

In this patch:

  • various updates to accomodate per-site administrator username settings on node/add/site form
  • constant value for "admin" and and configurable system-wide default variable ( added to node form at admin/content/node-type/site )
  • validation using user.module's user_validate_name
CommentFileSizeAuthor
#8 699250.patch3 KBmig5
#8 admin_config.png49.7 KBmig5
#3 hosting-697954.patch7.16 KBaaronbauman
#2 hosting-697954.patch7.58 KBaaronbauman
#1 hosting-697954.patch7.14 KBaaronbauman

Comments

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new hosting-697954.patch7.14 KB

re-patched.

see below.

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new hosting-697954.patch7.58 KB

fixes issue where pre-existing / legacy sites without an empty value for admin_user could not be edited through node edit form

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new hosting-697954.patch7.16 KB

removed some garbage from the previous patch.
sorry for the WOB.

Anonymous’s picture

Anonymous (not verified) commented

Sorry for the delay in reviewing your work.

Everything here works as expected, well done.

The patch no longer applies cleanly but that's because of work we've done. But I can clean that up when I commit. See the other ticket for some other comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

I committed a simplified version of this along with the other - see http://drupal.org/node/697954#comment-2942812

Thanks again, great work :)

adrian’s picture

adrian commented
Status: Fixed » Needs work

This form is already ridiculously complex to fill in, i believe we shouldn't add more stuff to it willy nilly, or risk sacrificing usability.

For a large majority of our use cases, we dont need to have this name be configurable by the person creating the site, as it is already configurable the moment they log in for the first time, and we then keep this information in our database and have to keep it in synch (or why do we have it otherwise)

Since this has already made it in, i believe that we should keep it , but make the element hidden by default. So the element shouldn't show up unless you specifically make it configurable.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned » mig5

OK, I'll work on it today.

We aren't keeping it in sync with what the user potentially changes it to later, so I am not against reverting it.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new admin_config.png49.7 KB
new 699250.patch3 KB

Please review this patch. Screenshot also attached to show the configurable options.

P.S after reading the IRC backlog, feel free to revert this, I was obviously wrong in assuming it'd be useful (and, I didn't hear any objections for 5 months in this or the other ticket #697954: user 1 name is hardcoded. allow provisioners to specify name for admin user. :) ) it hasn't made it into a release so removing it wouldn't require an additional hook_update to remove the fields etc. So now would be a good time.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (won't fix)

Reverted this feature per discussions...

  • Commit 5d685e1 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5: 
    #699250 by aaronbauman, mig5 - allow specification of uid 1 username
  • Commit f7ba8fe on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5:
    Revert "#699250 by aaronbauman, mig5 - allow specification of uid 1...

  • Commit 5d685e1 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5: 
    #699250 by aaronbauman, mig5 - allow specification of uid 1 username
  • Commit f7ba8fe on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5:
    Revert "#699250 by aaronbauman, mig5 - allow specification of uid 1...

  • mig5 committed 5d685e1 on dev-helmo-3.x 
    #699250 by aaronbauman, mig5 - allow specification of uid 1 username
  • mig5 committed f7ba8fe on dev-helmo-3.x
    Revert "#699250 by aaronbauman, mig5 - allow specification of uid 1...

  • mig5 committed 5d685e1 on 7.x-3.x-1995506 
    #699250 by aaronbauman, mig5 - allow specification of uid 1 username
  • mig5 committed f7ba8fe on 7.x-3.x-1995506
    Revert "#699250 by aaronbauman, mig5 - allow specification of uid 1...