I get this error:
Notice: Undefined property: stdClass::$format in user_comment_view() (line 2968 of /Users/alex/Sites/drupal/d7/modules/user/user.module).

Here are the steps to reproduce:
1) turn on signatures (in /admin/config/people/accounts)
2) give your user a signature (in /user/%uid/edit)
3) leave a comment on node
4) view the node
5) be saddened by the error you see

I have already been working on signature tests here: #276582: Tests needed: user.module which is how I found this.

CommentFileSizeAuthor
#2 comment.patch760 bytesbleen

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Critical » Normal

Nice catch. However, it doesn't cause Drupal to not function, so is not critical. We should definitely fix it though (along with tests).

bleen’s picture

bleen commented
Status: Active » Needs review
StatusFileSize
new comment.patch760 bytes

this patch works ... but I'm not 100% sure its the correct fix. Anyone want to chime in?

heine’s picture

heine commented
Status: Needs review » Closed (duplicate)

This is a duplicate of #520760: SA-CORE-2009-007 user signature format. Remember: user signatures should NEVER use the comment body format as the signature remains user controlled.

Breakerandi’s picture

Breakerandi commented

same problem here.. subscribe