Closed (fixed)
Project:
Chartbeat
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Jan 2010 at 15:17 UTC
Updated:
3 Jan 2014 at 01:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sumnercm commentedThere is a syntax error in the main code that will stop this module from working properly.
On line 58 the code:
(("https:" == document.location.protocol) ? "https://s3.amazonaws.com/" : "has a quote instead of semicolon. Change that line code to:
(("https:" == document.location.protocol) ? "https://s3.amazonaws.com/" : ;And your good to go.
Comment #2
ccshannon commentedActually, the code there is also throwing JS errors. A right parenthesis is missing.
The line, according to chartbeat's code, should be:
Now, I'm not getting JS error.
Please confirm. Thanks.
Comment #3
robloachThis what you meant? ;-) http://drupal.org/patch/create
Comment #4
ccshannon commentedYes, yes, I see. I've never created a patch, and should really get in the habit. Thank you for the assist!
Comment #5
robloachThanks a lot! Committed... Argh, messed up the commit message. Was trying to put your names in there :-( . Got your names in the release though! http://drupal.org/node/733774 :-)
Comment #6
ccshannon commentedHa! Thanks, Rob. It's the thought that counts! Next time I'll try rolling it myself. I need to get over my irrational fears, and just stick to the rational ones.