My gmap module is located at "modules/contrib/gmap." I just upgraded to cvs to check out the geocode implementation and I'm getting the following error on the gmap_location settings page:

warning: asort() expects parameter 1 to be array, null given in 
/mydomain/modules/contrib/gmap/gmap_location.module on line 261.

gmap_location.module looks like it is trying to asort the contents of $markers, which is generated from the markers folder location in the variable "gmap_markerfiles." The default for "gmap_markerfiles" at line 254 is "modules/gmap/markers."

I've looked around and I don't see where to update this variable. Either way, the default value should probably be:

drupal_get_path('module', 'gmap').'/markers'

Putting all non-core modules in a contrib folder seems to be a common practice and this should be fixed. I'll hold off on a patch since there's a good chance you are working on this code and it will change, but if you need one just give a shout and I'll roll it up.

Comments

webgeer’s picture

Status: Active » Fixed

I moved this drop-down generation to a separate function in gmap.module and fixed this bug.

seanbfuller’s picture

Works great. You're officially my hero.

Anonymous’s picture

Status: Fixed » Closed (fixed)