Bartik Color Module Integration

We've got this more or less working in the current Bartik and the non-modified color.module, with a couple color schemes, even.

Yes, anyone who wants to make a color scheme, feel free. We could use some beautiful ones. Code at Github.

Moving to bartik project. Needs review until CVS HEAD exists to review against.

This is mostly working in CVS HEAD; however the colours for:
- header bottom
- base color
are being overridden by defaults in the theme. I believe there was another issue that forced the background colour to be white in the theme? This may be resulting in the conflicts.

Please see attached screenshots.

Color module uses html generated by color.module and color.js applied to preview.png and modified by preview.css. Since bartik's preview.css is empty the preview block displayed on the appearance page is a default block and has no actual connection to the Bartik theme other than the colors displayed. The only css file modified by color.module in bartik is color.css, which, even though applied last, affects minimal parts of bartik.

preview.png is not appropriately sized to hold all the preview text and the header gradient. Base.png should be sized to match the theme's actual size. Base.png and preview.png don't really match the bartik theme unless you don't want to colorize the header bottom, tryptich, and footer areas, or any of the menu and other areas. It should at least have the menu tabs at the bottom of header top. And if the base color is supposed to be used, then color.css needs to be modified to override style.css.

The preview.css from Garland can be modified for Bartik, but I think this is something for a designer to look at because the base and preview pngs should be rebuilt.

Lastly, though it doesn't make any difference to bartik the way it is currently set up, the Garland theme doesn't apply the color module to style-rtl.css, so no color changes will be visible to clients using that style sheet.

I would love Steve to work on this, but since he hasn't for a while, I'm going to set this to unassigned.

Isn't this done? I'm not understanding what the addition concerns are here.... of course if color module is changed in core, we'll update the Bartik support, but that's on another issue. This issue is just about supporting the older D7 implementation of color module.

I have tested the color schemes as they exist currently, and I think this is done, unless #693504: Color.module does not support more than 5 colors and has hard-coded labels were to get in. The color schemes don't modify much of Bartik, it seems, except for the header, but I think that is fine. I have asked for clarification on the status of the Color.module changes in #693504: Color.module does not support more than 5 colors and has hard-coded labels.

I am not entirely sure what dcrocks is requesting to be changed in his comment #6.

The color module's preview block on the appearance page does not reflect the actual color changes to the theme, in particular the header gradient. It also shows a background color change that is not reflected in the theme. Preview.css needs to be modified to correct that. For both the old and the new color modules.

Ah, ok. Makes sense.

I see this now. Definitely needs a fix.

The color patch is in...

And know bartik is broken (appearance/setting) ;)

Bartik is not broken with the patch. Thus, setting to needs review.

To summarize what's happened and where we are now:

1) Bartik was made to work with the old color module. It worked fine, but was constrained by the 5-color, pre-labeled limit.

2) A movement was started to alter color module in core (thank you Steven Merrill) so that Bartik could rock colorizableness better. We wanted to be able to colorize the footer and other things. But we had to wait until core changed.

3) Last night, core changed: #693504: Color.module does not support more than 5 colors and has hard-coded labels

4) Bartik was updated to match the new syntax for the improved color module. I committed that this morning: #749276: Alter Bartik to run with the modified color module (from #693504)

5) So right now, Bartik color module implementation does the same thing it's done for a while. No new awesomeness exists yet.

6) Now we can change Bartik.... GO!

6b) Also we need to work on what dcrocks is saying in comment #6 and #9 above.

So here's 3 things that I think we should do (probably in this order):

1) Define more regions of Bartik to make re-colorable. Corolla is a good example of this (drupal.org/project/corolla), since it already works with the new color.module.

2) Define more color schemes (and axe ones that are not so good? (I personally don't like Fresh really at all)).

3) Address dcrocks' concerns by making the preview reflective of what happens in the theme. Garland is the only theme currently that really does this, as far as I know.

I think we might want to break #'s 1 & 2 into separate issues (especially since #2 would be a discussion of color palettes - fun :) ) and then regroup to do #3 here after they are done.

What does everyone else think?

Sounds awesome. Why don't we make three new issues, and retire this one, since it's original purpose is done. Go for it.

Cool. I won't have time to check on this for at least a day, though, so I'll let someone else create the issues & avoid creating the impression that I will be active on it tomorrow.

Here we go:

1)
#762462: Make footer background and sidebar block borders colorable

2)
#762468: Fix up the color schemes for Bartik

3)
#762474: Get Color Module Preview to work

I'm closing this issue. Please continue awesomeness on these other issues, or open a new one if something else comes up.

Thanks!