I realize that Seven is meant to be the admin theme, but since a user can change this setting and this is going to be a core theme, the Overlay styles need to be in place and the admin area needs to be functional (not sure if it is yet, but needs to be checked out).
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | bartik-edit-fix.png | 97.99 KB | emmajane |
| #15 | bartik-as-admin-theme.patch | 1.74 KB | emmajane |
| #14 | bartik-edit-in-overlay.png | 106.54 KB | emmajane |
| #13 | bartik-block-demo.png | 69.2 KB | emmajane |
| #13 | bartik-demo-content-off.png | 195.57 KB | emmajane |
Comments
Comment #1
jensimmons commentedI think it would also be a good idea to style Bartik so that it looks decent as the admin theme, whether the overlay is turned on or not. I think we are saying the same thing. It's just more of making sure Bartik works as an admin theme, then worrying about the overlay. (Boy I'm tired.)
Comment #2
jensimmons commentedComment #3
jacineYeah, we are saying the same thing. I know the overlay is an issue right now though. I had planned to test the admin area, and if other issues arise, post them separately to spread out the work. I'm hoping it's all good already! :D
Comment #4
jensimmons commentedYeah, my guess it that all those tables are a bit of a mess. They'll get core default styling, so maybe they are ok. I haven't been brave enough to look yet. So go for it!
Comment #5
jacineHere's a screenshot of the overlay right now.
Comment #6
jacineanother image.
Comment #7
jacineI committed overlay styles and did a pull request :D
http://github.com/jacine/Bartik/commit/fbed5e896b4266ca7034abc74e9a35f5a...
Comment #8
jacineHere's a screenshot.
Comment #9
willmoy commentedMoving to bartik project. Keeping at needs review until there's a dev release / CVS HEAD to review against. Critical because it would presumably block bartik in core.
Comment #10
dcrocks commentedThere is a line spacing problem on the theme 'settings' overlay that appears with any of the ver 7 'core' themes.
Comment #11
aspilicious commentedWho wants 7 themes....
Comment #12
jensimmons commentedThe screenshot in comment #10 has nothing to do with Bartik. That's the Seven theme. Let's only talk about how *Bartik* looks as the admin theme (in the overlay and out of the overlay) — not the Seven theme.
Comment #13
emmajane commentedAdded some minor tweaks to get Bartik working as an admin theme inside and outside of the overlay. Screenshots attached too.
Comment #14
emmajane commentedRolling this back to "needs work." On the content editing screen the content area is too wide. Not sure if this is really Bartik's fault, but I'm pretty sure it is.
Comment #15
emmajane commentedNew patch attached which also fixes the edit screen (and actually adds the admin.css file). Ready for review again.
Comment #16
jacineCommitted this to HEAD. I also ended up moving the overlay styles that were in layout.css to admin.css so they are all in one place. That makes more sense :)
Thanks emmajane!
I'm marking this fixed. :D
Comment #17
jacineIt totally slipped my mind, but we can't do an admin.css because it overrides modules/system/admin.css, and we need that. I moved the styles into style.css for now.
Do we want to choose a different name for this file? Maybe administration.css? We could pull in the contents of the core file into the theme, but it's still a moving target and probably not the best idea.
Comment #18
emmajane commentedI think it's fine to put all the admin-specific styles as a sub-section of styles.css. It's so short anyway that it doesn't really justify having its own file IMO.
Comment #19
jacineThanks emmajane, agreed. :)
Marking this fixed.
Comment #20
jensimmons commentedYea!!!!!!!!!!!!!!!!!!