Cat_menu: updating containers scatters menus everywhere

Fix committed for HEAD/4.7. Thanks.

Reopening the issue.

If a container has several categories, is *then* changed to hidden (but with menu items enabled so that the categories can be links under a higher level container), the link to the container is still visible in admin>>navigation but the categories under it get scattered all over the navigation menu- this seems both the opposite of the desired effect and a bug.

This does not seem to happen if the container has no categories initially, is then changed to hidden and the categories are added *after* the update to container status is made. It then seems to work as it should.

Same bug in the following situation also:

1.) Container has a category. cat_menu is set to enabled for container and 'enabled breadcrumbs' for assigned nodes.
2.) menu setting for container is changed to 'enabled breadcrumbs only'.

Result: Menu link for the container disappears from admin/navigation menu, but the link to the category is not disabled and needs to be manually done at admin>>menu.

My previous post was with 4.7.0 version.

Another menu issue- should I submit this against core menu system?

If I edit a container to add a description to its menu link from the 'Menu settings' item on the container's node edit form, the description stays until the preview, but vanishes the moment submit is clicked.

An update on category_menu issue (author: Ramdak at node/75899, closed now)

I am too tired to hunt through the issue list to find the right thread to post this, so I opted for a new post. Apologies.

This relates to the frequently experienced problem of menu links getting scattered all over admin>>navigation. I found out quite by chance that this may have nothing to do with cat_menu but everything to do with the underlying menu system.

The first time was when I built several static pages, created a menu for them and used the menu settings in the node form to add them to the menu. When I deleted the pages or something similar (oh, I think I deleted the menu), all the links to the pages got scattered.

The second time was today when I shut off cat_menu module and instead created the menu links by hand. Again, I manually created a menu and then the menu links to the containers and categories. When I deleted the menu at admin/menus, the menu links were all over the navigation menu once again.

Just marking this Jaza's attention.

updating title also for remembering better

For what it's worth, a similar scattering of menu items happens during taxonomy to category conversion:
http://drupal.org/node/90580

Scattered menu items are seen on quite a few 4.7.x issues, it seems. Apart from category_menu having serious bugs back then, it's not a good idea to customize auto-generated menu links, and also the menu system re-parents orphan menu items to the root of navigation menu... Difficult to make some sense in this mix.

But it doesn't matter now, I suppose, as 4.7.x times are gone, and this is 2.5 years silent issue.

Closing.

Update: It seems like I finally see what happens - I have a patch at #481280: Generated menu items vs. menu administration and weights now.