PHP 5.3 issues [#700466]

Upgraded to php 5.3.1 and got multiple error messages about "expected to be a reference, value given" in calendar, date,.... module. found a patch for all of them, except facted_search. The waring is the usual call by reference warning

warning: Parameter 1 to faceted_search_ui_faceted_search_init() expected to be a reference, value given in ..........   \includes\module.inc on line 487.

same problem with faceted_search_query_alter in facted_search_ui. I followed #360605: PHP 5.3 Compatibility a bit and tracked it back to the module_invoke_all calls in faceted_search.inc for faceted_search_init (one time) and faceted_search_ui_faceted_search_query_alter (two times).

I have no idea how to fix that in general and the discussions in #360605: PHP 5.3 Compatibility and other posts were a bit confusing. What I got is that there are problems with moudle_invoke_all calling functions with references??? For now I fixed my problems with replacing module_invoke_all with the actual function call e.g.:

module_invoke_all('faceted_search_init', $this);

replaced by

faceted_search_ui_faceted_search_init($this);

Any idea how to solve that in general? No one else having theses problems??? Thought I at least report it and post my tmp solution as even this took me couple of hours to figure out.

Comment	File	Size	Author
#2	faceted_search_php53fixes.patch	1.82 KB	berdir

Comments

Comment #1

ti2m commented 3 February 2010 at 13:55

Could it be that we can just remove the & without worries in case of complex data types being handed in????

then it would suffice to just change faceted_search_ui_faceted_search_query_alter and faceted_search_ui_faceted_search_init in facted_search_ui.module to

function faceted_search_ui_faceted_search_init($env){

and

function faceted_search_ui_faceted_search_query_alter($search, $query) {

Comment #2

berdir

German

Switzerland

commented 20 February 2010 at 00:27

Status:

Active

» Needs review

Status	File	Size
new	faceted_search_php53fixes.patch	1.82 KB

No, removing the & would break PHP 4 compatibility. The correct fix is to call the functions directly, as done in the attached patch. Please test and set to RTBC if it works.