I noticed that in 2.x-dev and 2.0-beta1 on row 817 and onwards, in services.module, it says:
// Check if it really loaded user and, for additional security, if user was logged from the same IP. If not, then revert automatically.
if ($user->sid != $sessid) { ...
Where's the ip check? In Services 6.x-0.15 the code was:
// Check if it really loaded user and, for additional security, if user was logged from the same IP. If not, then revert automatically.
if ($user->sid != $sessid or $user->hostname != $backup->hostname) { ...
Maybe some new magic is handling this in the later versions - just thought I'd mention it.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | node-ip-check.patch | 692 bytes | marcingy |
| #2 | node-ip-check.patch | 708 bytes | marcingy |
Comments
Comment #1
marcingy commentedThis comment need to be updated to reflect that the IP checking was removed in 6-x-2-dev branch some time ago. See http://drupal.org/node/401628. Updated status to reflect the fact that it is documentation that is wrong rather than the code.
Comment #2
marcingy commentedPatch to update comment
Comment #3
marcingy commentedwindows line ending fixed
Comment #4
gddCommitted, thanks.