I noticed that in 2.x-dev and 2.0-beta1 on row 817 and onwards, in services.module, it says:

// Check if it really loaded user and, for additional security, if user was logged from the same IP. If not, then revert automatically.
if ($user->sid != $sessid) { ...

Where's the ip check? In Services 6.x-0.15 the code was:

// Check if it really loaded user and, for additional security, if user was logged from the same IP. If not, then revert automatically.
if ($user->sid != $sessid or $user->hostname != $backup->hostname) { ...

Maybe some new magic is handling this in the later versions - just thought I'd mention it.

CommentFileSizeAuthor
#3 node-ip-check.patch692 bytesmarcingy
#2 node-ip-check.patch708 bytesmarcingy

Comments

marcingy’s picture

Component: Code » Documentation

This comment need to be updated to reflect that the IP checking was removed in 6-x-2-dev branch some time ago. See http://drupal.org/node/401628. Updated status to reflect the fact that it is documentation that is wrong rather than the code.

marcingy’s picture

Status: Active » Needs review
StatusFileSize
new708 bytes

Patch to update comment

marcingy’s picture

StatusFileSize
new692 bytes

windows line ending fixed

gdd’s picture

Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.