I've installed the version 6.x-1.1 from CVS, but I can't enable this module. I got the follwing warning:
This version is incompatible with the 6.15 version of Drupal core.

CommentFileSizeAuthor
warning.png11.64 KBm.sant

Comments

haffmans’s picture

haffmans commented
Priority: Critical » Minor
Status: Active » Closed (won't fix)

Please add the following line to the tcontact.info file:
core = 6.x

Normally this is added automatically by the Drupal packaging, so the packaged versions have the correct info. It may be better to use those instead of the CVS tags.

m.sant’s picture

m.sant commented
Status: Closed (won't fix) » Patch (to be ported)

Thank you for your reply and for this useful module.
I have a lot of modules installed via CVS and I never encoutered that problem.

I actually use drush to install and update core and modules. e.g. to install tcontact I run the following command:
drush dl --package-handler=cvs tcontact

CVS in not deprecated from the drupal community:
http://groups.drupal.org/node/17554

http://drupal.org/node/22676

http://drupal.org/node/93966

http://drupal.org/node/320

I hope it would be possible to fix this minor problem, so that all the users that manage drupal installations via drush or CVS will not have to patch tcontact after installing it.

Thank you in advance.
Regards,
Marco

haffmans’s picture

haffmans commented
Assigned: Unassigned » haffmans
Status: Patch (to be ported) » Needs work

Thanks for the info, I remember seeing some modules doing it the same way so I just followed suit (can't remember which ones exactly anymore, though). The info file is now updated, so the next release will work properly if deployed from CVS.

haffmans’s picture

haffmans commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fmjrey’s picture

fmjrey commented
Version: 6.x-1.1 » 6.x-1.x-dev
Status: Closed (fixed) » Needs work

Could you please move that fix to the 6--1 branch? Otherwise one needs to checkout HEAD.
I can see HEAD is still targeted to drupal 6, but what tells me that it won't change? Drupal 7 development will certainly be in HEAD, won't it?
Otherwise just make a 6.x-1.2 release and we're set.
Cheers

haffmans’s picture

haffmans commented
Status: Needs work » Fixed

From what I can see, the 'core' line was already in the .info file in the 6--1 branch all along.

I'm working on merging other changes in HEAD back to the 6--1 branch though (as we speak), as HEAD will indeed move towards Drupal 7 soonish.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.