Thanks for your great work. However, there is still a small bug when the ticker is implemented on the page as a side block. The Javascript error message from Firefox 1.5.0.4 shows:

Error: scrollPane has no properties
Source File: http://localhost:8080/modules/taxonomy_ticker/taxonomy_ticker.js
Line: 26

Also the IE says "Object Expected Line:5 Char:1"

Please look into that. Thanks!

Comments

mathieu’s picture

Strange one. I can reproduce, but I don't quite understand where it's coming from. This javascript error seems to be caused by a div that can't be found by the getElementById call... but the id shouldn't change when it's positionned in a block. (Does it?)

Maybe some javascript guru could help here... (or maybe that's the occasion for me to learn a bit more about it)

oweowe’s picture

Priority: Normal » Critical

I tested again and found this bug cannot be ignored.
The reason is once Taxonomy Ticker block is enabled somewhere in the Web page, it will prevent the admin>settings page unable to work. (All properties become read-only).

mathieu’s picture

Assigned: Unassigned » mathieu

It was just suggested (http://drupal.org/node/71240) that this is a kind of conflict with drupal.js. I'm having a look at this, but it looks like my javascript knowledge isn't enough. Still, I hope I'll understand and fix the problem quickly...

mathieu’s picture

Version: master » 4.7.x-1.x-dev

Just to make it obvious : this bug occurs in every version available now.

mo6’s picture

Priority: Critical » Normal

I've done some testing of the javascript code (and cleaned it up a bit) but don't see any errors (in FF 1.0.5.6).

hyperlogos’s picture

Having just located another error (and seen it patched) I come to this one. I too am getting this error (scrollPane has no properties, on line 26 of taxonomy_ticker.js.) Is it possible that in some situations, something is not being written out to the page properly, or similar?

I, too, am using FF 1.5.0.6

hyperlogos’s picture

Perhaps see http://www.dynamicdrive.com/forums/archive/index.php/t-6225.html.I figured out what makes this happen I think, it's when you don't include the block. However, I added the block and got:


Warning: Invalid argument supplied for foreach() in /home/martin/public_html/sites/www.hyperlogos.org/modules/taxonomy_ticker/taxonomy_ticker.module on line 26

Warning: join(): Bad arguments. in /home/martin/public_html/sites/www.hyperlogos.org/modules/taxonomy_ticker/taxonomy_ticker.module on line 29

Warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND 1 ORDER BY n.changed DESC LIMIT 0, 5' at line 1 query: SELECT n.nid, n.title, n.type FROM node n LEFT JOIN term_node r ON r.nid = n.nid WHERE n.status = 1 AND () AND 1 ORDER BY n.changed DESC LIMIT 0, 5 in /home/martin/public_html/includes/database.mysql.inc on line 120

So I don't know what's going on now, but enabling the block did stop the javascript errors. I've been pretty faithful (while not overzealous) about updating the database, but I do wonder if something bad happened to my taxonomy tables?

svladcjelli’s picture

I hacked away the js bug by wrapping everything in taxonomy_ticker.js with

if ( document.getElementById("scrollPane") != null ) { }

I now have the same SQL error as above poster.

mathieu’s picture

Status: Active » Fixed

I can't reproduce anymore. The last patch I commited (the one that gjmjr sent) did a lot of cleanup in the javascript code and fixed this, afaict.

Please test and reopen this bug if needed.

Anonymous’s picture

Status: Fixed » Closed (fixed)