This module includes the jquery cycle plugin in the .module file. This is a clear violation of the policy for 3rd party libraries in Drupal CVS. JQuery cycle is neither modified, difficult to find, nor no longer maintained by the original author. In fact, an updated version of the plugin can be found at the URL included in the module's views-rotator.js file, http://malsup.com/jquery/cycle/.

Including entire plugins modules creates conflicts when another developer or themer wants to use the plugin differently than you intended for this module. Please remove the plugin from the module and add either a requirement to place the third party code in a specific path or ideally, add a variable to define the path.

Comments

sun’s picture

Priority: Normal » Critical

True.

firstlut’s picture

Is that why it took a dump...er, uh, quit working?