Download & Extend
Issues

Aggregator: Feed URL Length Is A Limitation

Posted by greg_y on June 21, 2006 at 10:03pm
Project:Drupal core
Version:5.x-dev
Component:aggregator.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I cross posted this in Aggregator2 (at http://drupal.org/node/70021) but it's applicable to Aggregator as well ...

Issue: feed URL is capped at 255 characters. I see that this is because the field types VARCHAR (and CHAR?) are limited to that length under MySQL prior to 4.1.3 (?).

I have already run across some feed URLs that don't fit in that field length. For instance, I can't use custom Amazon feeds created here (http://www.onfocus.com/amafeed/) because they run about 350 characters. I'd imagine that with more and more on-the-fly RSS feeds -- such as Google News -- the 255 char limit will become more and more of a problem.

Sorry I don't have a specific suggestion to fix this, but I don't know enough about MySQL field types and indexing, etc, to write anything intelligent!

Login or register to post comments

Comments

#1

Posted by beginner on June 23, 2006 at 10:31am
Version:4.7.2» x.y.z
Category:feature request» bug report

#2

Posted by jt6919 on August 8, 2006 at 12:42am

I have the exact same problem....someone please provide some type of fix to this...

#3

Posted by Kjartan on October 4, 2006 at 12:59pm

http://tools.ietf.org/html/rfc2616#section-3.2.1

The HTTP protocol does not place any a priori limit on the length of
a URI. Servers MUST be able to handle the URI of any resource they
serve, and SHOULD be able to handle URIs of unbounded length if they
provide GET-based forms that could generate such URIs. A server
SHOULD return 414 (Request-URI Too Long) status if a URI is longer
than the server can handle (see section 10.4.15).

Note: Servers ought to be cautious about depending on URI lengths
above 255 bytes, because some older client or proxy
implementations might not properly support these lengths.

Looks like we have to move from a VARCHAR field to a TEXT field for the feed urls.

#4

Posted by coreb on November 15, 2006 at 5:36pm
Version:x.y.z» 4.7.x-dev

Has this been fixed for 4.7? It appears the fix (as suggested by Kjartan) is a change to the default DB schema, and I don't know how to patch against that.

#5

Posted by jt6919 on November 16, 2006 at 5:10pm

no - it hasn't been fixed, you have to figure out how to patch it yourself (the form and the db table)

#6

Posted by budda on November 19, 2006 at 3:27am

I fixed this issue with the feedparser module (still work in progress). The code to update the database to remove the limit is as follows:

      $ret[] = update_sql('ALTER TABLE {aggregator_feed} DROP KEY link');
      $ret[] = update_sql('ALTER TABLE {aggregator_feed} CHANGE url url TEXT NOT NULL');

You'll also need to remove the maxlength value in the aggregator.module form code
Search and destroy the following line:-

    '#maxlength' => 255,

#7

Posted by magico on January 17, 2007 at 12:15pm
Version:4.7.x-dev» 5.x-dev

Confirmed and important.

#8

Posted by ricabrantes on March 3, 2008 at 4:17pm
Status:active» fixed

This are fixed in current D5.x-dev

#9

Posted by Anonymous (not verified) on March 17, 2008 at 4:22pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#10

Posted by greggles on April 15, 2009 at 1:45am

This was never fixed, but there is http://drupal.org/node/218004

nobody click here