$db_prefix is assumed to be a string

SimpleTest should be run all on the same database. It takes special care to save your current db_prefix settings, changes them for testing, and then changes them back after the tests have finished? I'm not sure exactly why this is a problem?

Again, this is in the context of testing, not normal website operation. Are you testing CiviCRM?

Ah, I see what's going on. Seems like it might be valid.

Safer perhaps to check if $db_prefix is an array and use $db_prefix['default'] in that case?

Domain Prefix has this issue, and this fix:

/**
 * Check for existing table prefixing.
 */
function domain_prefix_get_prefix() {
  global $db_prefix;
  // Check for existing table prefixing.
  $prefix = NULL;
  if (!empty($db_prefix)) {
    if (is_array($db_prefix)) {
      $prefix = $db_prefix['default'];
    }
    else {
      $prefix = $db_prefix;
    }
  }
  return $prefix;
}

Now I wonder if I have to change my code, too. ;-p

This is a bug in core simpletest for d7. $this->originalPrefix can be an array.

protected function preloadRegistry() {
    db_query('INSERT INTO {registry} SELECT * FROM ' . $this->originalPrefix . 'registry');
    db_query('INSERT INTO {registry_file} SELECT * FROM ' . $this->originalPrefix . 'registry_file');
  }

Works for 7.x anyway: #716394: SimpleTest prefix should override $db_prefix when assigned.

Following up on #13, there are a couple of critical lines in the "716394-db-prefix-force.patch" (for D7) file that are not in the "D6-core-simpletest.patch" file distributed with SimpleTest (6.x-2.10 nor 6.x-2.x-dev). Banged my head on the wall for quite a bit on this one, so hopefully will save a lot of trouble for some D6'ers out there who are (like me) new to SimpleTest and use an array for $db_prefix.

Summary of the change: Out of the gate, we are asked to apply the D6-core-simpletest.patch to core. In doing so, bootstrap.inc's receives updates including (~ line 1029) the following:

        $db_prefix .= $matches[1];

that, on concatenation, resolves as something like "Arraysimpletest709493". As in the D7 patch 716394-db-prefix-force.patch we need the above line to actually be the following:

        $db_prefix_string = is_array($db_prefix) ? $db_prefix['default'] : $db_prefix;
        $db_prefix = $db_prefix_string . $matches[1];

The attached patch applies only this change.

The underlying assumption in rolling this patch against the (patched with D6-core-simpletest.patch) bootstrap.inc file is that folks are already running on the patched file per the distribution's INSTALL.txt

Please verify the fix does what it should.

(Brilliant module boombatower, btw. Many thanks!)

I'm getting a bunch of these in my php_error.log:

[30-Jun-2010 16:51:20] PHP Warning:  Table 'g365.simpletest475964simpletest475964semaphore' doesn't exist
query: SELECT expire, value FROM simpletest475964simpletest475964semaphore WHERE name = 'variable_cache_regenerate' in /Users/webchick/Sites/xxx.com/trunk/public_html/includes/database.mysql.inc on line 141

Presumably it's a result of this same thing because I'm connecting to both Drupal and CiviCRM databases in settings.php.

However, none of the patches here works for me. :(

I noticed #710978: Domain causes major testing errors as well, and we are using Domain Access, so I'll check that one before setting this to "needs work."

Ok. My problem was Domain Access-related. Ignore me! :D

good gosh, woman. you are using writing tests for simpletest d6 and domain access and Civicrm? And that 'variable_cache_regenerate' in the error msg looks ominous. You are a glutton for punishment.

Yes, my life has been a happy, happy place, let me tell you. ;)

The bug is in drupal7 as well ?

I am getting this Arraysimpletest as well because of this:

<?php $db_prefix = $db_prefix . 'simpletest' . mt_rand(1000, 1000000); ?>

What is the status of this bug ? Should I apply the patch submitted ? Do we need to submit a patch for d7 or only for this back ported version ?

Should be fixed.

I just lost a lot of time tracing this bug down, only that it is still part of the current stable AND current dev release. It does not look like this patch to fix the issue was applied

    $db_prefix = $db_prefix . 'simpletest' . mt_rand(1000, 1000000);

Marking as major because no one who uses anything than a trivial database setup can use simpletest

I agree

Needs to be re-confirmed using the lastest code.

I applied the patch in #10 to 6.x-2.11 and $db_prefix as an array now works for me. The release notes in 6.x-2.11 (http://drupal.org/node/935344 ) imply this issue is fixed but the patch in #10 wasn't applied.

#10: simpletest_db_prefix.diff queued for re-testing.

Since this was originally marked fixed, setting it back to that, since nobody complained in the intervening 8 years :)