Closed (fixed)
Project:
Bbcode
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
22 Jun 2006 at 00:25 UTC
Updated:
8 Jul 2006 at 08:33 UTC
Jump to comment: Most recent file
In upgrading from drupal 4.6 to 4.7 I noticed that all code blocks use <pre> now instead of <code>
Looks like this is because the newline processing puts the pre with class="bb-code-block" in place when restoring [code] blocks.. so the later processing that checks for a newline in the code block is never used. I changed the newline processing to simply put $pre[$i] back in place and the later processing then worked as before (alternatively, I guess move the check for a newline in the [code] block into the newline processing... or if the single line [code] isn't desired anymore, remove the later processing code)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | bbcode-filter.inc_patch.txt | 3.72 KB | mindless |
Comments
Comment #1
naudefj commentedGood point. Would you be able to prepare a patch to move the check for a newline in [code] to the newline processing section?
Comment #2
mindless commentedHow about this..
Comment #3
naudefj commentedIt looks good - I will test it later today and provide feedback.
Comment #4
naudefj commentedYour patch was committed - http://drupal.org/cvs?commit=34812
Thank you very much!
Comment #5
(not verified) commented