Download & Extend
Issues

Documentation problem with Database abstraction layer

Posted by foripepe on February 2, 2010 at 4:25pm
Project:Drupal core
Version:7.x-dev
Component:documentation
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Page: http://api.drupal.org/api/group/database/7
Original text

INSERT INTO node (nid, title, body) VALUES (1, 'my title', 'my body')

one would instead write:

$fields = array('nid' => 1, 'title' => 'my title', 'body' => 'my body');
db_insert('my_table')->fields($fields)->execute();

Last line doesn't seems good. I think this is a typo:
db_insert('node')->fields($fields)->execute();
Login or register to post comments

Comments

#1

Posted by mr.baileys on February 2, 2010 at 8:09pm
Priority:normal» minor
Status:active» needs review

Correct, good catch. Patch attached to correct the api docs.

AttachmentSizeStatusTest resultOperations
dbdoc.patch763 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch dbdoc.patch.View details

#2

Posted by jhodgdon on February 8, 2010 at 4:50pm
Status:needs review» reviewed & tested by the community

Looks good. I concur with the logic of the reporter and patcher, and it's a good patch.

#3

Posted by webchick on February 8, 2010 at 7:35pm
Status:reviewed & tested by the community» fixed

Thanks, committed to HEAD.

#4

Posted by System Message on February 22, 2010 at 7:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.