Add option 'Items per page' on admin/config/search/pages

This is a great idea, but it is too late to change Drupal 7, much less Drupal 6, for this new feature.

iosif.peterfi: It would be great if you could still provide the patch for D6 here. The solution for D5, which looks to be quite similar, is posted over at #166814: Change the number of results in search (which I've marked as a duplicate of this issue).

#33809: Make pagers not suck

I'd like to leave this open, specifically for the search module, for Drupal 8.

a) That issue may never be fixed in D8, who knows.
b) That issue mostly is for admin pages.
c) That issue proposes to create globals or variables and leave the settings pages to contrib modules.

The number of search results, IMO, since it is a visitor-facing and visitor-experience issue, needs a config setting exposed in core, on the search settings page.

Kinda stunning that "10 results per page" is hard-coded into Drupal core, with no way of changing it. (Especially since it seems this was identified nearly 5 years ago: http://drupal.org/node/33809)

Is there really no chance of adding a new hook or config setting into D6 or D7 that applications could modify, which would simply default to 10 for all existing sites?

D6 - no chance.
D7... As this is a feature request, you would need to get approval from Dries or webchick that this exception to the development process could be made, before I would even bother to make a patch. And in my opinion, the way to do it would be to make a setting that should go onto the Search settings page.

This is for D7 patch files. I fixed this change request. Kindly apply this patches.... Changes are made in the following files...
user.module
node.module
search.admin.inc - Kindly replace --- symbols to +++, and +++ to ---
search.install - Kindly replace --- symbols to +++, and +++ to ---

Sorry. This is a *new feature*. Drupal 7 is frozen for new features -- it is in beta release, and new features have not been accepted for several months. Please leave this as a Drupal 8 issue.

sub

Yes,

I read somewhere that patching drupal was really not recommended but I too would be interested in this patch. Just to clarify, does it:

1. Adjust the amount of nodes to display on a search results page?
2. Adjust the pager to reflect this changes?

(FYI The problem I have is that when printing the search results in Firefox, they seem to mess up and the one page seems to be printed across three - very messy. This patch would allow me to reduce the amount of results on a page and therefore print correctly in Firefox.)

Please do not change the version again! See comment #9. Thanks.

Please read my question again! I was asking if the patch is available for drupal 6 and if so where do I get it from?

I have no intention of changing the version again and accept that this change will only be available in Drupal 8. I see the patch for 7 but cannot see the one for 6!

I don't know of anyone making a patch for Drupal 6. It will never get added to Drupal 6, so probably not (new features are now material for Drupal 8). Sorry!

Just to clarify, you can feel free to ask questions about Drupal 6 on any issue, but changing the Version on the issue is not as welcome. (When you change the Project, Version, Component, etc. above the Comment field, you are changing it for the entire issue, not just for your comment.)

Break the tradition! I want a release for 6. This issue (a duplicate of it) is 7 years old and I think an obvious setting as this deserves a backport.

If you want a patch for 6, they you'll probably either have to write it yourself, or pay someone to do it. Core developers generally only work in later releases.

If you want better paging now, do it with Views.

Yeah just use Views, you can setup a "Search Terms" exposed filter, that works directly off Drupal's search index. Presto, instant search engine, fully customizable.

IMO, we should replace all calls to limit() in core with hard coded numbers, to use variables. But such a patch might be harder to get accepted, so I think that just fixing this for search is a good start. Attached is an updated patch.

@douggreen so far so good,but shouldnt the setting be exposed in search settings UI as well?

Subscribing

For D7 users plus, I've just implemented this in the search config module. Checkout from dev.

Positive feedback about this and the individual node search restrictions will help push out 7.x-1.1 release.

#8: user.module.patch queued for re-testing.

I can't believe this hasn't been addressed since D5! and pushing it off to this other issue ([#33809: Make pagers not suck]) is just forcing this to be a dead end instead of just providing a fix.

for reference #166814: Change the number of results in search has a patch for D6

#18: 702940.patch queued for re-testing.

Attached patch that addresses #20 and uses the new config system as well

would be good if someone reviews this before feature freeze..if we want to get this in drupal 8..

looks good to me.

Rerolled and rtbcing. It is pretty straightforward. Thanks rcross

Sorry, meant to remove min and max parameters. Someone might need to display more than 100 results

Good practice not to rtbtc your own patches :)

The number field validation function form_validate_number() passes if the field is empty. This would probably (?) cause issues¹, so mark this field as required. Also using '#min' => 1 would also prevent crazy things if -1 or 0 were entered.

¹ For example, PostgreSQL is more sensitive to garbage values being passed to it than MySQL.

;)
Thanks Alan, patch attached that addresses #33

missed a comma

#36: 702940-make_search_result_limit_configurable-35.patch queued for re-testing.

#36: 702940-make_search_result_limit_configurable-35.patch queued for re-testing.

Reroll

ok, someone in irc mentioned that we need some tests to get this rtbc

Edit Also beated me when adding tag

Tests added

I'm not sure we should add a separate setting for this. the search results listing could be provided by a view, and then would be configurable for more things than this separately. Moving back to CNR and tagging usability.

Also VDC tag.

#43: search-result_limit_configurable-702940-43.patch queued for re-testing.

Tagging.

I think we should postpone this on #2083717: Convert Search Results to Views (or close it as a duplicate or even make the other issue a META and this one one of its sub-issues).

reroll - couldn't make any decent interdiff out of this

Thanks! This is looking pretty good.

I have a few comments:

a)

+    // Results per page.
+    $form['results']['results_limit'] = array(
+      '#title' => t('Results per page'),
+      '#type' => 'number',
+      '#default_value' => $this->searchSettings->get('results_limit'),
+      '#description' => t('Number of results per page.'),
+      '#min' => 1,
+      '#required' => TRUE,
+    );

Can we just change the title to "Number of results per page" and cut out the description? We went to some lengths in #1559244: Clean up search settings page to clean up the search settings page, and this is exactly the type of clutter that we don't need. Actually, that other issue still needs a review. :)

b)

+    $this->assertNoLinkByHref('page=2', '3th page link is not found for keyword search.');

3th --> 3rd

c) I'd also like to call your attention to
#2123073: Move index.cron_limit setting to NodeSearch
The intent there is to decouple search.settings from node.module... so we might want to pass in the number of results per page as an argument to execute(), or else make Node and User search plugins have separate settings.

d) I think we need a test for User search too. It's interesting to me that the User module apparently was using 15 results per page, while Node was using 10. So probably the right fix for (c) is to make the setting plugin-specific.

This will need to wait for #2042807: Convert search plugins to use a ConfigEntity and a PluginBag (shouldn't be long now)

Other issue is taken care of. This is not related to Views.

And by the way this should be configured in the Node/User search plugin, not on the main search settings, I think?

Since 8.0.x-beta1 has been released, our policy at this point is No feature requests until 8.1.x. See #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Sorry, it's just too late for 8.0.x at this point, so even if we had a viable patch, the core committers would not commit it. So unless we decide this is a Task or a Bug (and I don't think it is), we'll have to delay it.

Still need this, but on D9

backport to D8.9.x
, for 9.3.x, see 66

backport to D9.0.x
, for 9.3.x see 66

D9.0.x with PHPLint fixes
and
D9.3.x with PHPLint fixes

D9.0.x with PHPLint fixes
and
D9.3.x with PHPLint fixes

D9.0.x with PHPLint fixes
and
D9.3.x with PHPLint fixes

see interdiff.

Hmm,I actually got something to work.

I'm still reviewing the patch.

Big thanks to those above that created the original patch.

was a challenging reroll though!

Re-rolled patch #74. Please review. fixed the custom command failed.

Thanks @Gauravmahlawat

One more (for my 9.0 site)

Here's a fix for 9.3 from comment #75

some unrelated stuff went into 75

here's the clean version. same interdiff as 75

new patch for the win

I have tested patch #79 manually and it is working as expected in drupal 9.3.x-dev version.
I can see the Results per page field in Results fieldset on search configuration page.
The results per page is configured successfully and this value being available to export in search.settings
Adding screenshot of testing results.

thanks @mitthukumawat

just need to fix the one remaining fail

Rolling a new patch

New patch

Trying again

New 9.3 patch

new interdiff

Yay! passing!

Thanks @mitthukumawat for the screenshots and illustrations and for testing this functionality.

Before:

New setting:

Configuration export:

Default value:

Needs a reroll yet again. After over 11 years, I think it's time to get this one done.

I also am adressing the core maintainers comment from comment number 52

see new patch

Ooops

try again

RTBC based on review in #702940-80: Add option 'Items per page' on admin/config/search/pages

Reroll was for recent changes to the test code. (this week).

Thanks for the quick review by @mitthukumawat.

I haven't read the issue, just taken a brief look a the patch.

+++ b/core/modules/node/src/Plugin/Search/NodeSearch.php
@@ -309,6 +309,8 @@ protected function findResults() {
+    $limit = is_null($this->searchSettings->get('results_limit')) ? 10 : $this->searchSettings->get('results_limit');

+++ b/core/modules/search/src/SearchPageListBuilder.php
@@ -255,6 +255,19 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+      '#default_value' => is_null($search_settings->get('results_limit')) ? 10 : $search_settings->get('results_limit'),

+++ b/core/modules/user/src/Plugin/Search/UserSearch.php
@@ -138,8 +150,10 @@ public function execute() {
+    $limit = is_null($this->searchSettings->get('results_limit')) ? 15 : $this->searchSettings->get('results_limit');

These can use the Null Coalesce operator.

And a questions, should the limits be defined in a constant?

Clarifying title.
Changing option name (in title, not (yet) in patch) to 'Items per page', to be aligned with Views pager options.
BTW, shouldn't all core pages be converted to Views?

The Search Module was approved for removal in #3476883: [Policy, no patch] Move Search module to contrib .

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3565780: [meta] Tasks to deprecate the Search module and the removal work in #3565783: [meta] Tasks to remove the Search module.

Search will be moved to a contributed project before Drupal 12.0.0 is released.