The logo displays correctly after upload through the theme configuration but does not create a link (you can't click on it) to the homepage.

Any feedback is appreciated.

Thanks.

CommentFileSizeAuthor
#13 source.jpg532.85 KBzdean
#13 theme.jpg194.64 KBzdean
#5 example.txt17.91 KBzdean

Comments

designerbrent’s picture

designerbrent commented
Status: Active » Postponed (maintainer needs more info)

Not sure what's gong one with that. What setting do you have for the logo on the theme settings page?

Can you check it in the base Blueprint theme?

Also, can you check the html to see what is printing?

zdean’s picture

zdean commented

If "site name" is enabled, the logo can be clicked. If not, it's just a static image. It's the same in the base theme.

This is what prints in the header region:

designerbrent’s picture

designerbrent commented

Hmm.. Looks like the input filter is removing the code.

Can you attach it via a text file?

zdean’s picture

zdean commented

sorry, attach what? you're talking to a nube :-)

zdean’s picture

zdean commented
StatusFileSize
new example.txt17.91 KB

nube figured it out :-)

designerbrent’s picture

designerbrent commented
Status: Postponed (maintainer needs more info) » Active

The code you posted has the link right in it. In particular: 

      <h1 id="logo"> 
        <a title= href=/multisite/><img src=/multisite/sites/default/files/BPSTARTER_logo.jpg alt= border='0' /></a>      </h1>

The only odd thing is that a few '' are missing from the code you posted. On my local copy, it looks a bit more like this:

      <h1 id="logo"> 
        <a title='' href='/multisite/'><img src='/multisite/sites/default/files/BPSTARTER_logo.jpg' alt='' border='0' /></a>      </h1>
zdean’s picture

zdean commented

I can confirm that those quotes ("") are missing on my source code.

FYI, I switched themes to Garland and the logo link worked fine.

designerbrent’s picture

designerbrent commented
Status: Active » Fixed
zdean’s picture

zdean commented
Status: Fixed » Active

sorry, designerbrent. I'm confused on this issue. Do you mean that the problem is with something I did in configuring a file or something? I don't think I would have altered anything that would have affected the logo linking. Please advise.

Thanks.

designerbrent’s picture

designerbrent commented

ZDean: Not sure what to say, really. I tried that theme you sent me several times and each time the link worked. Do you have some extra modules installed that might be causing a problem?

The source you posted above should work too, even with the missing "" marks. Is something over the logo that causes it to be unclickable?

zdean’s picture

zdean commented

I don't have very many modules, so I will test out deactivating them and see if that gets me anywhere. Will report back.

thanks for all your help.

zdean’s picture

zdean commented

Still no luck.

I went ahead and did a fresh installation of Acquia Drupal (only default modules enabled) and Blueprint and still couldn't get the logo link to work.

Here is what I did step by step:

1. Installed Acquia Drupal
2. Downloaded Blueprint theme (latest dev) and placed in sites/all/themes folder
3. Added a logo.png file to the Blueprint theme folder (this is missing from the default download of the theme)
4. Downloaded Blueprint Framework files and placed in Blueprint theme folder
5. Enabled the Blueprint theme
6. In the Blueprint theme configuration page, I disabled "site name" and left "logo" enabled.

That's it. No other files, modules, etc. were fiddled with. The logo prints on the page but does not link to anything.

I've included screenshots of the theme settings page and the source code of that page.

Am I missing a step or doing something wrong in the steps above?

Thanks for your help with this.

zdean’s picture

zdean commented
StatusFileSize
new theme.jpg194.64 KB
new source.jpg532.85 KB

oops. the screenshots...

designerbrent’s picture

designerbrent commented
Status: Active » Fixed

Alright, I think I got this nailed. Your screen shot of the settings page is what made it click for me. I was thinking you were setting the logo only to display via the theme settings at the bottom of the theme settings page (Blueprint specific) and not unchecking the "Site name". When i tried it that way, I got it to fail so I was able to fix it.

Here is my suggestion:

If you leave the "Site name" box checked, and use the drop-down box near the bottom of that page to select "Logo Only" it will not display the logo but will put the site name in the Alt text. Otherwise, the site name gets disabled and does not print. So as soon as Drupal.org runs the package script, (it only runs every 12 hours for dev releases) you will be able to download the updated version that fixes the issue you found.

Thank you for your patience and help on this issue.

zdean’s picture

zdean commented

I can confirm that this has been fixed. Thank you!

Now you've got me thinking...what is the purpose of the "Items Displayed in Header" drop-down in the "Theme Specific Settings" area if that option can be checked/unchecked at the top of the page anyways?

designerbrent’s picture

designerbrent commented
Title: logo is not linking » Fix $logo and $site_name to work via the PHPTemplate check boxes.
Assigned: Unassigned » designerbrent
Status: Fixed » Needs work

Much of the back story can be read here: #317153: $logo support

My thinking was to enable a way to do either method. However, I had actually forgotten about the upper page settings when I did that because I never use them myself. I can see, though, that this has introduced some confusion that needs to be addressed.

My problem with the default phptemplate method of doing things is that when you disable the "Site name" variable via the PHPTemplate checkbox, the logo does not provide a text version of the site name, and I think that hurts the SEO of things.

So, I think what needs to happen is that this whole feature needs some more work in blueprint to make it handle this correctly.

designerbrent’s picture

designerbrent commented
Status: Needs work » Fixed

This should now be all resolved. Totally re-factored and cleaned up the code for this. Thanks for your help in raising this issue, ZDean.

http://drupal.org/cvs?commit=326020

zdean’s picture

zdean commented

Thank you very much. You've been very responsive on all the issues!

I'll test the new version...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.