Sometimes, ffmpeg can't convert the videos (i.e. with Windows codec Wmv MSS2). The result is an empty node without thumbnail and without linked video, but this node is published anyway.

Should be possible for Flashvideo to process the ffmpeg output and to avoid the node creation in case of this kind of error?

I'm taking a look on flashvideo.module, but I don't know too much PHP. Could somebody guide me, please?

Thanks in advance.
Best regards.

Comments

daniel.merino’s picture

daniel.merino commented
Title: Don't create node when ffmpeg conversion returns errors » Not to create node when ffmpeg conversion returns errors
ore’s picture

ore commented

flashvideo.module

  // Convert the video. Adding ' 2>&1' sends results of the command into the $ffmpeg_data variable.
        $ffmpeg_data = shell_exec($command .' 2>&1');

        // If they provide a metadata command path, then we will want to execute that now.
        if (!empty($params['metadata_cmd_path']) && strstr($output_path, '.flv')) {
          $metadata_command = $params['metadata_cmd_path'] ." -U '". $output_path ."'";
          $metadata_command_message = t('Metadata Command:') .' '. $metadata_command;
          shell_exec($metadata_command);
        }
      }

      // Check to make sure the new file exists.
      if (file_exists($output_path) && filesize($output_path) > 0) {

Look for that in flashvideo_convert(...) function.

After it converts it checks the filesize and does a few things. if the filesize is 0 then it doesnt do those and heads into post op operations. In there is does some db file stuff but it also changes the status of the node to 1 'published'

function flashvideo_perform_postop(...)

 // If they opt to change the status of the node.
  if (flashvideo_variable_get($node_type, 'status', 1)) {
    // Update the status of the node.
    db_query("UPDATE {node} SET status = 1 WHERE nid=%d", $oldfile->nid);
  }

you would want to do something around this area. you need to know that it has failed from the previous function, perhaps with the files passed through or something. I havnt checked what happens with those so thats where i would start.

hope this helps. I havnt given line numbers as my line numbers will be way out compared to the latest release.

gimi37’s picture

gimi37 commented

This happens to my site as well. I noticed that if the file name has any character other than a-z and 0-9 ex. & or ë it fail to convert it, and node is posted any way. Any idea how to address the file name issue when it has one of other non-standard characters?

Thanks