Updating to 6.x-2.0-rc4 broke my site. After running update.php I get the following error on my the page that uses quicktabs:
Fatal error: Call to undefined function array_fill_keys() in {sitepath}/sites/all/modules/quicktabs/quicktabs.module on line 199

Comments

pasqualle’s picture

martinwjones’s picture

we are running php 5.1.6 - which is integrated in our linux distribution
looking at that link it appears this actually requires PHP 5 >= 5.2.0
what a shame :-(
I hope there are no security implications of staying on the previous version.

pasqualle’s picture

Issue tags: +Release blocker

there are no security issues (identified) in -rc3..

QT 6.x should not require php 5.2 so issue #633630: Contents of tabs in Drupal.settings js variable? needs to be fixed correctly.

chrislynch’s picture

You can work around this by declaring your own array_fill_keys function as follows:

function my_array_fill_keys($keys,$value){
	$return = array();
	foreach($keys as $key){
		$return[$key] = $value;
	}
	return $return;
}

I have named mine my_array_fill_keys and changed the call on line 199 so that I can still work on PHP 5.2 servers, but if you remove the "my_" this will serve for any calls to array_fill_keys.

bradweikel’s picture

Priority: Normal » Critical

This needs to be noted very clearly on the project home page so people know about the problem before they download this module, and rc4 should be removed from the recommended releases so that responsive site maintainers aren't punished for upgrading.

bradweikel’s picture

You should also document this in the release notes ( http://drupal.org/node/685288 ) for the same reason -- so site maintainers don't waste time investigating a critical bug that they can easily avoid by using a previous release.

pasqualle’s picture

release node updated

pasqualle’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dragan_r’s picture

Hey chrislynch. Thank you for a solution. It works for me.

www.twitter.com/dragan_r

scalp’s picture

I've used this module on other sites and it is outstanding! Unfortunately, the project I'm currently working on wants the latest updated release of any module being used only and they are not using php 5.2. From reading this thread am I understanding correctly that the next release (or rc) of QT will not require 5.2 php? It's confusing because in #3 it looks like that's the goal, but then the issue got labeled as fixed.

bradweikel’s picture

scalp - correct. the cvs checkin in #8 fixed the issue, but it isn't in a release yet.

scalp’s picture

Excellent. Thank you for the quick reply. I look forward to the next release.