Matrix Textfield type always gets required [#703874]

I'm using a matrix field that has checkbox and textfield columns. None of them are required and I've verified that they are stored in the db correctly. Yet when I go to the form, all of the textfields throw required errors (even though they are not). It doesn't happen with checkboxes.
I commented out line 515 and that skips verification to get around this, but obviously not the ideal fix

if ($col['#required'] == TRUE && $values[$row_key][$col_key] == '') {
//form_error($element[$row_key][$col_key], t("Cell at %col x %row is required", array('%row' => strip_tags($element['#first_col'][$row_key]), '%col' => strip_tags($element['#header'][$col_key+1]))));
}

Comments

Comment #1

emilyf commented 3 February 2010 at 19:57

Also, I tried to test this on latest dev but that appears completely broken when i upgrade to it. It was unusable so I stuck with the alpha release.

Comment #2

aasarava commented 29 July 2010 at 18:44

I ran into this bug too. What you really need to do is look in the _matrix_process() function for the following code:

    case 'textfield':
      return array(
        '#type' => 'textfield',
        '#size' => $element['#size'],
        '#required' => $element['#required'],
        '#default_value' => $default,
        '#required' => TRUE,
      );

Notice the #required attribute is set twice, and the second time it is TRUE? Comment out the second one.

Can any of the maintainers let us know if there was some reason for forcing the textfield to TRUE? Or is this just a typo that needs fixing?