Closed (works as designed)
Project:
Revision Deletion
Version:
6.x-1.0-rc2
Component:
Documentation
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2010 at 20:03 UTC
Updated:
23 May 2011 at 17:15 UTC
1) I am using Revisioning and this allows for there to be pending revisions before they get published. Would this module take that status into consideration?
2) Likewise does the revision use a modified date in case the revision is modified?
Comments
Comment #1
rdeboerHaving looked at the code, it appears that this module does not take the "pending" status of the Revisioning and Revision Moderation modules into account. It's more an age-based purge than a status-based purge (which is fair enough). Therefore you have to be careful with the automatic periodic deletion (via cron) as "age" is defined relative to "now" rather than relative to the "live" (current) revision. So you could end up accidentally removing pending revisions, once they're older than the specified age, which may not be desirable.
This could easily be enhanced through a patch.
In manual mode the module does list the pending revisions (as the ones newer than the currently published) and you can choose to delete or not delete them by ticking/unticking the box in front of their revision id.
Comment #2
pumpkinkid commentedHey Rik, I actually have been using this module in conjunction with Revisioning.
I don't mind it deleting pending revisions as in our case we have it remove them after 4 months. We have explained to our users that this is the case.
The only thing that I have yet to verify is if a current "unpublished" revision would count as a revision that should be deleted by this module...
Comment #3
rdeboerHi kiddo,
Agree, it may boil down to a matter of educating your users.
As far as the "current unpublished" revision (i.e. a yet-to-be-published or previously published node) goes, I think you'll be safe (but give a try on a test node).
Because if the module were to delete the current revision (wheter published or not) the data-integrity of the node would be broken. From a database point of view a node simply must have 1 current revision, or the whole thing falls in a heap. So the module would have to make, say, the most recent of the remaining revisions the "current", or alternatively delete the entire node.
Rik
Comment #4
attheshow commented