DanProbo [danprobo]

Hello, and thank you for applying for a CVS account.
I am adding the review tags, and soon somebody will review your theme.

I installed your theme and tried it out. It would be nice to have header region. I wouldn't describe it as "tableless" ... here is just a snip of your page.tpl.php:

<table border="0" cellpadding="0" cellspacing="0" id="content">
  <tr>
    <?php if ($left) { ?><td id="sidebar-left">
      <?php print $left ?>

Well first off, I would get rid of tables if at all possible. Though it is not against Drupals standards for coding (to my knowledge anyway), its just a bad practice in general. Using tables to lay out the content of a site is a thing of the past. I like think the design, simple, yet functional.

The main thing you need to do in order to follow Drupals coding standards is make sure that all your blocks of php end with a simicolon. Example, here is an excerpt from line 24 of your page.tpl:

<?php print $front_page ?>

It looks like about 30% of the PHP in your .tpl files is formatted this way, this should be fixed. In order to follow Drupals coding standards it would have to be done as follows:

<?php print $front_page; ?>

You have an empty PHP declaration on line 11, that should be removed.

You should remove lines 22, 24 of your .info file, the version and project attributes are added by drupal.org when its uploaded through CVS. More information here - http://drupal.org/node/171205

When uploading a theme to the Drupal.org repository, it is important to make code as clean and readable as possible. Even above and beyond the documented Drupal coding standards. The PHP syntax you are using, though completly valid, is not what is recommended. Here is an excerpt of on of your variables
<?php if (isset($primary_links)) { ?><?php print theme('links', $primary_links, array('class' => 'links', 'id' => 'navlist')); ?><?php } ?>

Though that is completely functional and actually a little shorter, but remember, this theme is available for the world to download, you wanna make the code is as clear as possible. @kiamlaluno writes about this some here. In Drupal themes it is encouraged to write your if statements like this :

<?php if (isset($primary_links)) : ?>
  <?php print theme('links', $primary_links, array('class' => 'links', 'id' => 'navlist')); ?>
<?php endif; ?>

Most of your logic is written like the first example, I would fix this.

You need to remove information from the CVS headers of your files, this information is added by Drupal.org when uploaded through CVS.

This:

<?php
// $Id: page.tpl.php,v 1.28.2.1 2009/04/30 00:13:31 goba Exp $
?>

Should be changed to this:

<?php
// $Id
?>

Read about it here - http://drupal.org/coding-standards#cvs

Well, still not a fan of the table based layout. From my are understanding they are bad for SEO and accessibility, but to each his own I guess. I don't see anything else that really breaks Drupals coding standards.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.