prevent installation of image CAPTCHA module when no GD available

CommentFileSizeAuthor
#6 image_captcha_profile_include.patch620 bytesnahed
#1 704110_image_captcha_requirements_01.patch6.07 KBsoxofaan

Comments

soxofaan’s picture

soxofaan commented
Status: Active » Needs review
StatusFileSize
new 704110_image_captcha_requirements_01.patch6.07 KB

this patch includes the patch from #668152: image captcha option is not showing in administration section

soxofaan’s picture

soxofaan commented
Status: Needs review » Active

hello world

soxofaan’s picture

soxofaan commented
Status: Active » Needs review

hello testbot

soxofaan’s picture

soxofaan commented
Status: Needs review » Fixed

http://drupal.org/cvs?commit=342202
http://drupal.org/cvs?commit=342204

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nahed’s picture

nahed commented
Version: 6.x-2.x-dev » 6.x-2.2
Status: Closed (fixed) » Needs review
StatusFileSize
new image_captcha_profile_include.patch620 bytes

This is new features doesn't work for the captcha 2.2 in the installations profiles. The function module_load_include('module', 'image_captcha') doesn't work.
For more details: http://drupal.org/node/241086
Please find the patch attached.

soxofaan’s picture

soxofaan commented

marked #811262: Fails during installation profile as duplicate

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

I supplied a patch in #811262: Fails during installation profile that was complete identical to behnas' patch in #6 above, so am marking it reviewed :)

soxofaan’s picture

soxofaan commented
Title: prevent installation of image CAPTCHA module when no GD available » Prevent installation of image CAPTCHA module when no GD available (with support for installation profiles)
Version: 6.x-2.2 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs tests

Fixed for CAPTCHA 6.x-2.x by http://drupal.org/cvs?commit=374224

to be ported for CAPTCHA 7.x-1.x

having a test for this would also be nice

soxofaan’s picture

soxofaan commented
Issue tags: +low-hanging fruit

tagging

soxofaan’s picture

soxofaan commented

marked duplicate #833496: Can't call module_load_include from within hook_requirements

soxofaan’s picture

soxofaan commented

marked duplicate #833680: Call to undefined function _image_captcha_check_setup() when setting up a profile with image_captcha enabled

john.karahalis’s picture

john.karahalis commented

The patch seems to work for us. Thanks for putting it together, behnas and DamienMcKenna.

Any chance this can be packaged up into a stable release soon? Because drupal.org make files do not support patches, this fix can't be used in profiles until it becomes available in a supported version of the CAPTCHA module.

soxofaan’s picture

soxofaan commented

at Open Publishing Lab at RIT in #13:

I'll make a new release (CAPTCHA 6.x-2.3) after I commit the patch at #810534: Fix CAPTCHA session reuse. This is a critical issue, with patch and simpletest coverage, but the change introduced by the patch is pretty major, so I'd like some real world testing from different people before I'm confident that committing the patch does not break other stuff. So far I got one guy reporting that the patch works for him, but I'd like some more eyes on it.
So if you want a new stable release soon, please help at #810534: Fix CAPTCHA session reuse.

john.karahalis’s picture

john.karahalis commented

Thanks for the info, soxofaan.

The patch provided in this thead did seem to work for us, but I'm not sure if that's what your talking about. Unfortunately we can't make testing a priority right now, but I'm going to keep an eye on this thread. If we find time and it would help get a release out, we'll definitely see what we can do.

Thanks!

wundo’s picture

wundo commented
Issue summary: View changes
Status: Patch (to be ported) » Closed (outdated)