Error is in here
http://api.drupal.org/api/function/user_preferred_language/6

If $account->language is not set & php is set to report all errors then it throws a Undefined property: stdClass::$language error. Happens with UID=0.

CommentFileSizeAuthor
#6 0001-manage-empty-language.patch453 bytesgábor hojtsy
#2 0001-manage-empty-language.patch475 bytesmarvil07
#1 drupal-704158-D6.patch777 bytesmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new drupal-704158-D6.patch777 bytes
marvil07’s picture

marvil07 commented
StatusFileSize
new 0001-manage-empty-language.patch475 bytes

maybe !empty instead of isset, but it works

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Reviewed & tested by the community

empty works for me :)
Tested on a site that was producing this error and patch makes it go away.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 7.x-dev

Bugs are fixed in Drupal 7 first. The function is identical, so the patch should apply to D7 just fine (and looks good).

dries’s picture

dries commented

Can't we remove && $account->language with the extra isset()?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 0001-manage-empty-language.patch453 bytes

Yup, the !empty() should already cover that. Looks like a pretty trivial change.

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

Committed to D7. Moving to D6.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6 as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.