Project:Service links
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

.

AttachmentSize
D7_port-service_links.patch54.47 KB

Comments

#1

patched version: [EDIT: download link removed]

#2

Has there been any other work/consideration on this port to Drupal 7?

I'd love to see this one "ready" soon.
I'm currently building out several D7 sites, and rely heavily on the service links module.

I will download this patched version, and test it out on one of my current installations and report back.

#3

This patch "is" working well...
I'm using the image only version in nodes. The links version seems to be spotty.

Also, I was able to appropriately re-theme the image rendering to use my own images in a custom folder, so the underlying theme layer seems to be working well...

However, there IS a major issue in the linked version here.

hook_perm is gone in favor of hook_permission and must be updated in order for anyone but user 1 to see the service links.
http://drupal.org/update/modules/6/7#descriptions_permissions
The following snippet fixes things for me. I put in my own descriptions here, and added the restrict access flag on the administration permission.

<?php
function service_links_permission() {
  return array(
   
'access service links' => array(
     
'title' => t('Access service links'),
     
'description' => t('Allow users to interact with the service links and share posts.'),
    ),
   
'administer service links' => array(
     
'title' => t('Administer service links'),
     
'description' => t('Allow users/roles to administer the service link settings.'),
     
'restrict access' => TRUE,
    ),
  );
}
?>

#4

subscribing

#5

Status:needs review» fixed

as I see similar patch was already committed
http://drupalcode.org/project/service_links.git/commit/1f85cfc

and a better D7 version is already available, so this task can be closed..

#6

@Pasqualle, thank you for the first efforce!
@himerus thank you for the correction!

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.