Time Limits

In the node_limitnumber.module line 135-154 it has:

$form['settings']['time'] = array(
    '#type' => 'select',
    '#title' => t('Set a time frame'),
    '#default_value' => $settings['time'],
    '#description' => t('Create the limit of nodes per time frame'),
    '#options' => array(
      'none' => t('No Time Limit'),
      'daily' => t('Daily'),
      'monthly' => t('Monthly'),
    ),

Can I just add weekly and annually to this and it will work or is it not just that easy?

Ok maybe not found this:

// Continue checking as a simple limit since the OG check is over
  switch ($settings['time']) {
    case 'none':
      $q = "SELECT * FROM {node} WHERE type = '%s' AND uid = %d";
      $result = db_query($q, $node->type, $user->uid);
      $num = db_affected_rows();
      if ($num >= $settings['limit']) {// We have the data, now we check the limit
        return TRUE;
      }
      return FALSE;
      break;
    case 'daily':
      $q = "SELECT * FROM {node} WHERE type = '%s' AND uid = %d AND created > %d";
      $day = strtotime(date('Y-m-d'));
      $result = db_query($q, $node->type, $user->uid, $day);
      $num = db_affected_rows();
      if ($num >= $settings['limit']) {
        return TRUE;
      }
      return FALSE;
      break;
    case 'monthly':
      $q = "SELECT * FROM {node} WHERE type = '%s' AND uid = %d AND created > %d";
      $month = strtotime(substr(date('Y-m-d'), 0, 8) .'01');
      $result = db_query($q, $node->type, $user->uid, $month);
      $num = db_affected_rows();
      if ($num >= $settings['limit']) {// We have the data, now we check the limit
        return TRUE;
      }
      return FALSE;
      break;
  }
  return FALSE;
}

Need to add two more for it to work but how and what?

I have looked up the functions at php.net. I'm not a php or mysql person, I have a php and mysql book but it is packed up in storage from a move.

for weekly:

case 'weekly':
      $q = "SELECT * FROM {node} WHERE type = '%s' AND uid = %d AND created > %d";
      $week = strtotime(substr(date('W'), 0, 8) .'01');
      $result = db_query($q, $node->type, $user->uid, $week);
      $num = db_affected_rows();
      if ($num >= $settings['limit']) {// We have the data, now we check the limit
        return TRUE;
      }
      return FALSE;
      break;

and for annually:

case 'annually':
      $q = "SELECT * FROM {node} WHERE type = '%s' AND uid = %d AND created > %d";
      $year = strtotime(substr(date('Y'), 0, 8) .'01');
      $result = db_query($q, $node->type, $user->uid, $year);
      $num = db_affected_rows();
      if ($num >= $settings['limit']) {// We have the data, now we check the limit
        return TRUE;
      }
      return FALSE;
      break;

Then add:

$form['settings']['time'] = array(
    '#type' => 'select',
    '#title' => t('Set a time frame'),
    '#default_value' => $settings['time'],
    '#description' => t('Create the limit of nodes per time frame'),
    '#options' => array(
      'none' => t('No Time Limit'),
      'daily' => t('Daily'),
      'weekly' => t('Weekly'),
      'monthly' => t('Monthly'),
      'annually' => t('Annually'),
    ),
  );

Is this close to right how bad did I mess things up?

Made a patch but it needs some work.