.

CommentFileSizeAuthor
#1 D7_port-sharethis.patch6.73 KBpasqualle

Comments

pasqualle’s picture

StatusFileSize
new6.73 KB
lpalgarvio’s picture

Share and Service Links would need a port as well

robloach’s picture

Instead of a port, think a refactoring would be better?

lpalgarvio’s picture

the approach of the 2.x version of Services, Share and ShareThis seems okay (provided the modules do work well - i couldn't get ShareThis working, the others did work well)

but it's also ambiguous with AddThis and AddToAny around. i choose the AddThis module for a site i'm building.

if there was going to be a refactoring, i would suggest create an API supporting the many services around (but not the modules that are around), implementing a selection box to choose which service to use, and listing the options and fetching the relevant links, javascript and css for the service.

so the service (addthis, addtoany, etc) would provide the links, the images, the scripting and themes, which you would select on the module config page. which links would be available would also be choosen by the admin, as it works for most of these modules.
there could be integrations for the block system, for views, for cck, for panels and display suite.

maybe even add custom links with their images (per drupal theme).

ofc this would deviate a lot from the current objectives, so i don't think it's much practical to do.
also to note, i don't know if the other services around are as good as AddThis; AddToAny service seems solid, but the existing module lacks some things.

reviews of similar modules here - http://groups.drupal.org/node/28680

jvalencia’s picture

I'm rewriting the whole thing. There should be a good upgrade coming soon!

Edit: Just went back and read that comment... Not the sentiment I hoped to express.
I'm writing a module that puts the standard widget into drupal at each node for Drupal 7. I think its different than what the current module does...

astutonet’s picture

I see this module as an excellent tool.

I particularly do not like of the AddThis and AddToAny services.

I also realize that many people want to embrace fully the D7, but the lack of some modules used in D6 prevents this migration.

Since there is a patch that converts the version of the ShareThis D6 in to D7, why not offer this patch as a development version while the new version does not arrive?

That would stop some users from D7 remained orphans, because they are not all the users which know to enter the information of the patch into a php ...

Let's be practical?

jvalencia’s picture

http://drupal.org/sandbox/jvalencia/1159576

is the sandbox project if you want to start looking at the new version.

robloach’s picture

Status: Needs review » Reviewed & tested by the community

This is great, jvalencia! Thanks so much for taking this on... Would you like maintainership of this project to stick the 7.x branch up? I could get the branch started for you.

robloach’s picture

Title: D7 port of sharethis » D7 port of sharethis (Clean Up)
Status: Reviewed & tested by the community » Needs work

I've just commited what you had in your sandbox and renamed some of the functions to remove the _official_ names. I've also added you as a maintainer of the module, so please feel free to commit as you wish. The module probably needs some clean up, as I didn't quite test it.

Thanks so much for the help on this, jvalencia. I put up the development snapshot here: http://drupal.org/node/1172400 .

jvalencia’s picture

Thanks Rob!
Much appreciated. :-) I'm still no Drupal pro, so whatever help you could give, I'm sure it would only make the module better :-)

jvalencia’s picture

http://drupal.org/node/1181422 for the first release of the rewrite.

jvalencia’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.