Here's a very first cut at trying out a postgresql version of the MySQL tables for the Subversion module. So far I am not seeing any errors but I am not familiar with how the module works to really stress test it. Looking for feedback.

CommentFileSizeAuthor
#2 subversion.install.patch.txt2.39 KBmarkc
pgsql.dump2.15 KBmarkc

Comments

halkeye’s picture

halkeye commented

The biggest thing i've noticed so far is that you are using sequences, drupal has its own internal incrementing id system, so we shouldn't be using sequences.

I'll try to setup a postgres server tonight / tommorow for more testing..

any chance you could patch the install file?

markc’s picture

markc commented
StatusFileSize
new subversion.install.patch.txt2.39 KB

Re incremental ID, subversion_repositories has an auto_increment rid field so I presumed one would be needed in the pgsql version. This patch is untested, just a textual conversion of what I loaded into pgsql by hand, plus removal of sequence. pgsql seems to use double quotes around field names like mysql uses a backtick. I've removed all double quotes so I suspect it won't load for that reason alone.

There is an issue with at least one sql call. On line 999 of subversion.module...

  $sql .= 'GROUP BY subversion_name'. tablesort_sql($header);
to
  $sql .= 'GROUP BY subversion_name,a.uid,u.name,a.status'. tablesort_sql($header);
halkeye’s picture

halkeye commented
Version: 4.7.x-1.x-dev » master

patch didn't 100% work
i'll update cvs sometime tommorow with all my recent changes (been storing mostly in subversion for testing purposes)

halkeye’s picture

halkeye commented
Status: Active » Fixed

Postgres support in cvs now

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)