Becky Kinney [beckykinney]

Thanks for applying for a CVS account. I am adding the review tags, and somebody will review the code you have attached; I am also changing the status to make clear there is code to review.

Reviewing is done from volunteers; please have patience if this can take a little more time than you would expect.

/**
 * Implementation of hook_form().
 *  This is the note taking form for single page notes.
 */
function notes_form($form_state) {
  $form = array();
  global $user;
  $node = node_load(arg(1));  
  $nid = $node->nid; 
  $note = db_fetch_object(db_query('SELECT * FROM {note} WHERE nid=%d AND uid=%d', $nid, $user->uid));

  // If a noteid exists, then get the existing values.
  if ($note) {
    $noteid = $note->noteid;
    $content = $note->content;
  }
  else {
    $noteid = NULL;
    $content = '';
  }

The implementation of hook_form() is used from a module that implements a node type; in that case, the modules needs to implement other hooks that the module doesn't define.
Clearly the function is not an implementation of hook_form().

  $node = node_load(arg(1));  
  $nid = $node->nid; 

If the code just needed the node ID, then it should use arg(1). Then, arg(1) contains the node ID only when the page viewed has a path like node/2; if the user is visualizing his user profile, then arg(1) doesn't contain any node ID (the same is true when the user is not watching a node).

I don't see then any relevant differences between notes_form(), and notes_book_form(); the code could be in a single function.

There have not been replies in the last week. I am marking this application as won't fix.