Currently there is a checkbox and 2 radios buttons for choosing content type, authors, and terms. This was done on purpose so the module would support the following:

* want content type of node being shown
plus
* some selected content types

Unfortunately, the current UI can cause confusion because it defaults to "all" (e.g. all content types). So, if you were to check the checkbox for the current node's content type, it would really help you because you still have the "all" radio button selected. It works as designed if you instead choose the "use the ones selected below" radio button.

In the short term, I could have it default to "use the ones selected below" so the user has to consciously choose the "all". But, I don't think this is the best solution for the long term.

I'm open to suggestions.

Kristen

Comments

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Hmmm... why can't I edit the issue text above... annoying.

The phrase above "it would really help you because" should be "it wouldn't really help you because".

Kristen

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Does not seem like we will ever be able to change an issue which is kind of crazy when you wrote something wrong in the first place...

http://drupal.org/node/288592

Kristen

green monkey’s picture

green monkey commented

:-) ... you know you're in trouble when you're caught talking to yourself in a Thread

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Seriously! Good to see someone else is joining in ;)

Btw, I started reworking the path filtering logic... hope to get it checked in tomorrow!

-k

green monkey’s picture

green monkey commented

being in "the zone" is hard to explain to some people... gald to see I'm not alone.

I use to have a staff, and the ladies would figure out when I was in "the zone" and would ask me to approve things I would normally debate - they also learned to get a witness - as I would stongly deny ever having the discussion

It took me awhile to catch on - almost caused me to seek professional help - lol :)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Active » Needs review

One *simple* way to deal with this would be to:

1) get rid of the checkbox altogether

2) keep the two radio buttons

3) for the options when choosing content types (etc), add an option at the top of the list for matching the current page, e.g.

Use the content types selected below.

* Content Type of the page being shown
* Blog
* Event
* Page
* Story
...

Use the users (authors) selected below.

* User (author) of the page being shown
* joe - joe@blah.com
* suzie - suzie@foo.org
...

Use the ABC terms selected below.

* Any ABC terms of the page being shown
* Coolness
* Wicked
* Loving It
* Awesome Possum
...

Seems like this would make sense but would like some feedback.

Kristen

green monkey’s picture

green monkey commented

you know those boxes always got me the first few times.

its one of those darn interpretation things and UI shouldn't leave any room.

how about this

get rid of top check box - so only two now

first one could read

Use the content type of the page being shown (all content types active [or available])

??

green monkey’s picture

green monkey commented

it could even be shorter

[x] Use content type of page shown (all content types active).

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

I still need to work this out because my suggestion in comment #6 won't handle all scenarios. I want to handle:

1) only match the content type of the current page

2) match the content type of the current page along with selected content types

3) only match selected content types

and a maybe these NEW ones:

4) doesn't match the content type on the selected page

5) doesn't match the content types selected

but maybe 4 & 5 are JUST TOO CONFUSING to your "normal" user and should be thrown out.

If so, then comment #6 does handle 1, 2 and 3.

I'll think about your suggestion as well.

Thanks,
Kristen

green monkey’s picture

green monkey commented

Cool! I like 4 and 5.

Pretty covers it.

would you consider adding a feature to this

either display a message

No matches found

.or.

Just not show the block

reason: Empty things always look broken

dpellerin’s picture

dpellerin commented

This really threw me for a loop and I hope this is the right place to comment. Here's how I would expect it to work.

Assume I'm using a vocabulary called "Facility".

When selecting "Use All Facility terms" I would expect that the block would only show nodes that have a Facility term that matches a Facility term on the current node. If the current node does not use ANY Facility terms, I would expect an empty block to be returned.

When selecting "Use the Facility terms selected below", I would expect that the block would return nodes that contain the Facility term used by the current node, that also match my selection in the list. Again, if the page uses not of the terms I've selected, an empty block should be returned. Also, if I don't select anything in the list, and empty block should be returned.

So basically selecting "Use all Facility terms" would be the exact same as selecting "Use the Facility terms selected below" and then selecting all entries in the list.

You may want to re-word the phrases as well. Using my Facility vocabulary example:

"Use the Facility terms of the page being shown" might become "Activate filtering by Facility terms"
"Use all Facility terms" becomes "Match Facility terms"
"Use the Facility terms selected below" becomes "Match the Facility terms selected below"

Dana

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks for the feedback!

So, were you mainly confused by the wording, or was the functionality not working as you expected, or both?

Your explanations above *are* how it is supposed to work for (your examples for "Use All Facility terms" and "Use the Facility terms selected below"). Did it not do that? If so, then that's a bug.

Do you understand what "Use the Facility terms of the page being shown" is supposed to be?

At this point, I think the simplest solution is what I've outlined before:

* get rid of checkbox
* add "match the current page's term/content type/etc" to the select list for the second radio button
* change wording as necessary

Do you think this would make things more intuitive?

Thanks,
Kristen

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Fixed

This has been checked in and will be in dev once the next cron runs.

You must run update.php after upgrading the module in order to preserve you old block settings.

Kristen

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
Issue summary: View changes

cleaning up my issues list