Posted by moshe weitzman on February 5, 2010 at 3:02am
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | dblog.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | moshe weitzman |
| Status: | needs review |
Issue Summary
For some unholy reason, we delete all watchdog entries when a user cancels own account. Thats a security nightmare. Someone can wreak havoc and then cover all their tracks. Attached patch removes these watchdog deletes and smartens our dblog report to show rows where the uid is no longer found.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| dblog.diff | 1.39 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch dblog.diff. | View details | Re-test |
Comments
#1
I think the idea is that people can completely remove their accounts from the system, but since logs get cleared by cron, and contrib could add this hook, I agree it's madness doing it like this. Also clearing watchdog logs can be an expensive operation if there's a lot of rows so best left for cron.
Patch looks great, needs a testbot (or manual) run before commit.
#2
I totally agree.
#3
Committed to CVS HEAD. Thanks!
#4
Poor tests... everyone is forgetting these :) The attached page removes the tests that test this.
Another thing I noticed: Those events then show up as Anonymous, but link to the profile page of the deleted user. Maybe we should add something like "Deleted user (uid: 27)" instead?
Not covered by the patch, we need to get HEAD to pass again first :)
#5
Erm, with patch this time.
#6
Oopsie. :P
Committed to HEAD.
#7
I implemented the suggestion in #4.
#8
#7: deleted_user.patch queued for re-testing.