After seeing some of the cool changes that are being made to the video module, I'm trying to refactor this code so that we can allow remote files. The idea here is to push the getID3 code into its own module that implements hook_audio(). I don't think it breaks any of the current behavior but I'd love to get some testing and feed back from people.

CommentFileSizeAuthor
audio_getid3_module.patch22.12 KBdrewish

Comments

drewish’s picture

drewish commented
Status: Active » Needs review
zirafa’s picture

zirafa commented

This looks promising. I will try out this patch soon and post a more constructive response.

drewish’s picture

drewish commented

i've actually started trying to incoroprate q0rban's image support into it. i've got it in my sand box now.

drewish’s picture

drewish commented

link to my sandbox is: http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/drewish/audio/

drewish’s picture

drewish commented

the split is finished up in my sandbox. i'm working on the image support right now but i need to make sure that the module still works right when audio_getid3 isn't enabled.

drewish’s picture

drewish commented
Status: Needs review » Fixed

Okay, I've committed this, there's probably still bugs but I want to get it out to a wider audience.

zirafa’s picture

zirafa commented

cool. is it in your sandbox or CVS?

drewish’s picture

drewish commented

it's in CVS for both 4.7 and HEAD.

zirafa’s picture

zirafa commented

Seems to be working pretty well so far! (Tested on 4.7). I like having the ability to turn off the submodules. I think this also paves the way for making remote files possible.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)