On checkout: cart contents are not translatable

I think this is wrong: uc_pnslation_node_get_translationroduct_get_description($item)

subscribing

The patch looks good, except that I would try to optimize the part that sets $desc. It looks like in whether or not the translation module exists this call is always performed:

$desc = check_plain($item->title) . uc_product_get_description($item);

So no need to have it inside and outside the conditional.

+1

subscribing
+1 for translatable content in Ubercart

The only review this patch has received was #7, who suggested a change and moved the status to "needs work". His concern has not been addressed by you or anyone else, so the patch is not ready to commit. Even then, I'd like to see someone do some real testing on this. I do not use the translation module so I can't test it myself. But I was under the impression that having a separate nid for translated product content causes lots of problems, for instance stock isn't decremented correctly because stock levels are associated with a nid. That said, even if your patch doesn't cause problems, it may not be the right thing to do.

I updated the totsubo's patch from #5 with the comments firewing1 gave in #7.

I don't know Übercart well enough to decide if this is the best solution, but this makes translating Übercart a little less troublesome.

A slightly different approach is attached. A new checkbox, "Use source translation node when adding products to the cart", is added to the cart settings. When this is enabled, product titles will be translated in the cart and checkout and the localized name will be stored against the order, but translated products will be grouped together in the cart and reports - however, this is at the expense of allowing different product settings per language. Seems to work well if you are using i18sync module and the fields sync patch that was committed recently.

Further work is needed to support attributes and some other modules, but as this new option is disabled by default it could still be committed as-is.

Pay no attention to the bot behind the curtain...

Can't trust the test results yet - bot is misbehaving. I reported the above failure as a testbot bug, see #1096900: Releases should not be tested.

subscribe

#14: uc_cart-translation.patch queued for re-testing.

This is unlikely to be fixed in 6.x now, as nobody tested the patch I uploaded two years ago in #14. This could still be changed in 7.x if someone wants to work on it.

I've this patch already applied to one live site for over 1 year, so this patch actually has been tested under 6.x