GHOP #90: Support the new views feed argument
merlinofchaos - June 24, 2006 - 07:46
| Project: | Atom |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | kyl191 |
| Status: | needs work |
| Issue tags: | GHOP |
Jump to:
Description
The attached patch supports views 'feed' selector. Simply enabling it gives all views that have the feed selector an atom feed and an icon.
Downside: atom.module doesn't come with an atom icon, so it just uses the RSS icon. This could easily be fixed by providing an icon with the module.
Downside #2: There ends up being 2 'atom' feeds listed on the view; one global one for the site, and one for the feed itself. The main atom feed should probably only be added if drupal_is_front() is true but I didn't want to force that decision on you.
Upside: Atom feeds a-plenty.
| Attachment | Size |
|---|---|
| atom_views_feed.patch | 6.52 KB |
#1
I'd like to be the first to call this "awesometastic."
#2
Now that I'm actually paying some attention to this module, please re-roll this against DRUPAL-6--1.
#3
Since Views for D6 isn't stable (that I know of), go ahead and roll for D5.
#4
Linking up to http://code.google.com/p/google-highly-open-participation-drupal/issues/...
#5
I've started reading the code of views and atom modules and I'll release the new patch soon.
BTW, about the icon:
I'll use the standard feed icon: http://feedicons.com/
Is that OK?
#6
That one is preferred, though use the one that comes with Drupal in the misc directory (feed.png).
#7
task was re-opened due to lack of response and is now claimed by alexandrebfarias.
#8
Opening task because it's not really claimed by tmadeira.
#9
Assigning it to myself as it's now claimed by me (alexandrebfarias on Google Code).
Sorry about the delay in upgrading this, but I've been busy with some other things.
#10
Back up for grabs.
#11
#12
aclight & co. : I'm still here, working on the code. Have one question for now -
return theme('feed_icon', url($url));- As far as I can tell, to fix downside #1, this is where I pass the url for the atom feed icon, right?As I mentioned to webchick, the going is slow cause I'm not that familiar with PHP - but I'm still going to finish it even if I have to work beyond the ghop deadline.
#13
You haven't given much context, so I'll say, yes
theme('feed_icon', url($url));is correct as long as...1) $url actually needs to be processed by
url()(it hasn't already been throughurl()already)2) $url points to the URL of the feed - the place where the feed reader will need to go for the content you're syndicating. the theme function already knows where to find the feed icon when you tell it 'feed_icon'.
3) returning
theme(... is the result of a function that should be just processing the feed iconPut it inside some code and upload it and it'll be much easier to give you a clear answer and help point you in the right direction if it's wrong.
#14
http://drupal.org/project/coder is a decent module for getting automated help on your code if you're still too shy to post a preview patch.