Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This patch should make a checkbox option for each form so that it may clear any messages set by drupal_set_message() on redirect.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | customdestination-no_t.patch | 15.61 KB | deekayen |
| #5 | customdestination-enable_boot.patch | 15.82 KB | deekayen |
| #3 | customdestination-clear_dsm_w_tests.patch | 13.76 KB | deekayen |
| #3 | Test result screenshot | 416.29 KB | deekayen |
| #3 | Edit form screenshot | 34.12 KB | deekayen |
Comments
Comment #1
deekayen commentedThis should finish it out. I couldn't help but add some other code cleanup as part of this patch. In addition to code style is a change to the permissions on hook_menu() since they seemed inconsistent. Otherwise, this patch adds a checkbox to the configuration form of each custom redirect that unsets the messages set during the page request of the submission.
Comment #2
deekayen commentedPrevious patch was against DRUPAL-6--1, which is apparently no longer where the rest of the 6.x updates were going, so this is against DRUPAL-6--1-4, which right now is also HEAD. It also includes simpletests and a bugfix for sending the wrong array key to
menu_valid_path().Comment #3
deekayen commentedSpelling fix in @file block of .test and a screenshot of the tests passing.
Comment #4
deekayen commentedComment #5
deekayen commentedApparently the previous patch wasn't working in all cases. The broken case I was shown had a CCK content node submission that redirected correctly to another node, but the message about the node creation was not unset.
This patch adds an implementation of
hook_enableto force the module weight to be + 1 more than any other module. It also adds a$_SESSIONvariable to track across to the next page load to let a newhook_bootimplementation also attempt to unset any messages sincehook_exitapparently wasn't catching everything. I left thehook_exitin place, figuring it wasn't hurting anything.I was never able to reproduce the case provided in the previous, offline patch review, but I'm hopeful that now I'm at least somewhere in the arena of overkill.
Comment #6
denes.szabo commentedSorry deekayen, but as I know we does not translate the schema api: http://drupal.org/node/332123
So, your patch should not contain t() around field descriptions.
Comment #7
deekayen commentedEasily resolved...