Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.On a new install, profile field is set to 0, but the form settings to change the field, only shows up if a profile field exists.
Patch fixes it so you can pick the field at any time.
(PS, why are you doing it this way? having the id in settings worked really well previously)
| Comment | File | Size | Author |
|---|---|---|---|
| drupal.adsense.patch | 1.23 KB | halkeye |
Comments
Comment #1
kbahey commentedThis has already been fixed, and should be in today's tarball (check the version against what you have).
The reason I am doing it this way, is that it paves the way for site owner revenue sharing. Each co-owner would setup their google ID.
Also, the author revenue sharing already relies on a profile field, so using the same field for everything provides consistency.
Comment #2
tmj2k7 commentedHonestly, there should still be a choice. With siteowner revenue sharing off, you should be able to just enter a siteid via the module. Why should you have to enable an extra module, add a field and utiilize it just to get your adsense id inputed. It isn't really consistent if you arent using revenue sharing. It is to be expected that a feature like revenue sharing would need to have integration with a user component (profile). It is not expected that a sitebased feature like one adsense id would require a user based integration.
Comment #3
halkeye commented$Revision: 1.37 $ $Date: 2006/06/25 04:35:28 $
fetched it from cvs yesterday, if it fixed though, its all good.
Comment #4
kbahey commentedThe version you should use for 4.7 is this one:
$Revision: 1.34.2.4 $ $Date: 2006/06/25 19:44:54 $
If you are using CVS (no reason why you should), the version should be
$Revision: 1.38 $ $Date: 2006/06/25 19:44:29 $
Comment #5
(not verified) commented