This is hotfix for 6.x-2.1 release allow you to utilize htmlpurifier library in standard libraries directory of your drupal instance, with the help of Libraries API http://drupal.org/project/libraries

Current location become a problem when using with drush_make, see #628198: Allow library downloads into a directory that already exists Other than that just a matter of personal preferable :)

Thanks.

CommentFileSizeAuthor
#1 htmlpurifier-library.patch3.17 KBwik

Comments

wik’s picture

wik commented
StatusFileSize
new htmlpurifier-library.patch3.17 KB
ezyang’s picture

ezyang commented
Status: Needs review » Postponed (maintainer needs more info)

Thanks for the patch! I'm trying to figure out how to make this transition work properly without breaking users autoinstalls (as it stands, if they don't have the libraries API installed and they update their files, everything breaks horribly).

wik’s picture

wik commented

Easiest way it's to bundle/utilizing libraries API(two methods) with module, prefixing methods with "htmlpurifier_", but I would consider this one only if there no other choice :)

It's could be done as BC wrapper, which could check if there libraries API installed already and use it if so, or use simplified internal methods if it's not installed.

ezyang’s picture

ezyang commented

I've posted an issue here: #709526: How to gracefully add support for libraries

I've hacked in a BC layer on my local copy (I can share if others are interested), but there's another interesting problem namely now you can't /disable/ the module.

j0nathan’s picture

j0nathan commented

subscribing

ezyang’s picture

ezyang commented
Status: Postponed (maintainer needs more info) » Needs work

#709526: How to gracefully add support for libraries was resolved. Blocking on me removing the dependency and making sure everything checks out.

traviscarden’s picture

traviscarden commented

Sweet! Subscribing.

traviscarden’s picture

traviscarden commented
Title: decouple location of htmlpurifier library » Decouple Location of htmlpurifier Library with Libraries API

Making title more "skimmable".

ezyang’s picture

ezyang commented

I spent some cycles today looking at the new approach, and I've found that we need to be careful about cases in which a user has an old-style installed HTML Purifier, and then they install libraries. Patch needs more work.

ezyang’s picture

ezyang commented
Status: Needs work » Fixed

Fixed in CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.