The 6.x version works great unless you need to have pricing based on product attributes. Any chance of getting the attributes code in 5.x ported to the 6.x version of the module?

Thanks!

CommentFileSizeAuthor
#2 708434_attribute_pricing.patch16.58 KBfenstrat

Comments

peroski’s picture

peroski commented

I second that and would be happy to chip in some funding to help :)

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Active » Needs review
StatusFileSize
new 708434_attribute_pricing.patch16.58 KB

Here's a patch with a copy of the attribute pricing functionality from d5.

I've basically converted these two commits to d6/uc2.

Also updated the precision on price field to be inline with uc2.

Prices are still using the old uc_currency_format() and will need to be updated to uc_price() for any sort of compatibility with the price alter system (e.g. uc_vat), but will have to have a shot at that when I have more time.

hozt’s picture

hozt commented

Fantastic!

I have applied the patch and have had excellent results with testing. I will do more testing thorough testing in the next couple of days.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Tested briefly and seems to work, as you say it doesn't work fully with uc_vat as it should be calling uc_price(), but this is a good start. Committed to HEAD and will be available in the next -dev release, thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.