Download & Extend
Plus 1 » Issues

Create hook for access control

Posted by voxpelli on February 9, 2010 at 12:16pm
Project:Plus 1
Version:6.x-2.6
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I needed to be able to add additional conditions to determine whether voting should be allowed or not for a node - and I of course didn't like the idea of having to hack Plus1 to accomplish that.

I suggest adding a new hook, similar in design to hook_node_access(), that is used to determine when to show a widget and when to allow a vote.

That makes it possible for me to add extra conditions in my own module - I can for example say that all nodes not tagged with "Voting" shouldn't be voteable or say that all nodes contained added to a group should inherit a vote-setting from that group etc.

Attached is a patch that adds such a hook - "hook_plus1_access()".

AttachmentSize
plus1_access_control.patch2.9 KB
Login or register to post comments

Comments

#1

Posted by voxpelli on February 9, 2010 at 12:24pm

First patch was missing the new plus1.api.php file - rerolling

AttachmentSize
plus1_access_control.patch 4.43 KB

#2

Posted by voxpelli on February 9, 2010 at 4:54pm

Hadn't tested the patch enough - sorry for that - reroll with fixes for typos etc.

AttachmentSize
plus1_access_control_2.patch 5.07 KB

#3

Posted by NancyDru on December 30, 2010 at 7:03pm

Very interesting idea - I like it a lot. However, isn't the standard type of return from hooks like this TRUE/FALSE?

#4

Posted by voxpelli on December 30, 2010 at 9:32pm

Hmm - yes - can't remember right now why I didn't use that. Might be to avoid mixups between NULL and FALSE perhaps.

I'm currently a bit tied up in trying to get OAuth 3.x stable - due to that I may not give very good response in this issue queue right now.

#5

Posted by NancyDru on December 30, 2010 at 10:06pm

That's okay. I think I have a pretty good number of the fixes ready to go.

#6

Posted by NancyDru on January 6, 2011 at 8:15pm

See fivestar_fivestar_access().

#7

Posted by NancyDru on January 7, 2011 at 4:43pm

This is ready to go.

#8

Posted by NancyDru on January 8, 2011 at 5:39pm
Status:needs review» patch (to be ported)

#9

Posted by NancyDru on January 13, 2011 at 5:07pm
Status:patch (to be ported)» fixed

Committed to 6.x-2.x-dev.

#10

Posted by System Message on January 27, 2011 at 5:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here