Validation saves the values: error prone. [#709110]

This is not a good way to save the values: in the validation callback.

You probably did this, to make sure the block-module (or another) did not already call the drupal_goto(), but this method is error-prone:
* If validation of another value on the block fails, your values are saved nonetheless.
* If your insert/update/delete fails, you may end up with a broken database: your content is not saved, but other block-setting may, or may not be saved. result is unknown and hence "dangerous".

What is your reason for not using a submit callback?

Comment	File	Size	Author
#6	709110-cleanup-odd-validation-save-logic.patch	2.43 KB	neclimdul
#5	0002-Cleanup-odd-validation-save-logic.patch	2.76 KB	neclimdul
#2	709110_split_up_validation.patch	3.74 KB	neclimdul

Comments

Comment #1

ngmaloney commented 11 February 2010 at 15:18

Assigned:

Unassigned

» ngmaloney

I'll look into this and work on a patch.

Comment #2

neclimdul

He/Him

commented 29 April 2010 at 16:35

Title:	VAlidation saves the values: error prone.	» Validation saves the values: error prone.
Status:	Active	» Needs review

Status	File	Size
new	709110_split_up_validation.patch	3.74 KB

Here's a patch. Did a little additional cleanup around the validation callback as well to make it more resilient.

Comment #3

ngmaloney commented 4 May 2010 at 15:20

neclimdul - Thank you for taking the time to do this. I'll roll it into CVS ASAP.

Comment #4

ngmaloney commented 18 May 2010 at 14:34

Status:

Needs review

» Needs work

neclimdul - I tested the patch and it is throwing the following errors:

warning: Wrong parameter count for array_search() in drupal-6.16/sites/all/modules/block_titlelink-HEAD/block_titlelink.module on line 36.
warning: Wrong parameter count for array_search() in drupal-6.16/sites/all/modules/block_titlelink-HEAD/block_titlelink.module on line 41.

Running on php 5.2.6