Small tweaks to get the module to work properly on D7. Thanks for getting your module ported so early!

CommentFileSizeAuthor
#5 709130-robotstxt-D7.patch6.04 KBdave reid
#1 709130-robotstxt-D7.patch2.21 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 709130-robotstxt-D7.patch2.21 KB
hass’s picture

hass commented 
+++ robotstxt.info	9 Feb 2010 14:20:04 -0000
@@ -5,5 +5,3 @@ core = 7.x
-
-version = 7.x-dev

Why do you remove the version? Maybe someone deploys directly from CVS...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Then they should be using CVS deploy.

http://drupal.org/node/231036:

version (Discouraged)
The version string will be added by drupal.org when a release is created and a tarball packaged. However, if your module is not being hosted on the drupal.org infrastructure, you can give your module whatever version string makes sense.

Users getting their modules directly from CVS will not have a version string, since the .info files checked into CVS do not define a version. These users are encouraged to use the CVS deploy module to provide accurate version strings for the admin/build/modules page for modules in directories checked out directly from CVS.

Because Drupal core uses a slightly different packaging process than contributed modules, the core modules have a version line predefined. This is an exception to the rule, not the model for contributed modules.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Any progress on this hass?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 709130-robotstxt-D7.patch6.04 KB

Found a couple more things with the changes in D7's menu structure and documentation standards.

hass’s picture

hass commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.