After applying #497394: Clean up 960.css & 960-rtl.css there's still a problem:

In the screenshots the area marked with blue border and red content has grid-11 alpha omega
and the CSS is:

.omega {
margin-right:0;
}
960.css?N (line 75)
.alpha {
margin-left:0;
}
960.css?N (line 71)

In the RTL however the CSS is:

.omega {
margin-left:0;
margin-right:10px;
}
960-rtl.css?N (line 37)
.alpha {
margin-left:10px;
margin-right:0;
}

The problem is that .omega-RTL should not declare margin-right

Comments

yhager’s picture

yhager commented

subscribing

dvessel’s picture

dvessel commented
Status: Active » Fixed

Could you look into the latest dev build?

Here's the reason it has a right margin. The ".grid-X" classes have margins on both sides while .alpha and .omega cuts them out. The RTL .alpha and .omega adds those margins back in while swapping their location at the same time. It might not make sense but those margins had to be added back somewhere.

This is the fix I added:


/* A more specific selector used in case .alpha and .omega is appled to the same block. */
.container-12 .alpha,
.container-16 .alpha {
  margin-right: 0;
}

.alpha {
  margin-left: 10px;
}

.omega {
  margin-left: 0;
  margin-right: 10px;
}
dvessel’s picture

dvessel commented

I just committed a better fix. The previous one should have worked but it wasn't straight forward.

/* `Grid >> Global
----------------------------------------------------------------------------------------------------*/

.grid-1,
.grid-2,
.grid-3,
.grid-4,
.grid-5,
.grid-6,
.grid-7,
.grid-8,
.grid-9,
.grid-10,
.grid-11,
.grid-12,
.grid-13,
.grid-14,
.grid-15,
.grid-16 {
  float: right;
  margin-left: 10px;
  margin-right: 10px;
}

/* `Grid >> Children (Alpha ~ First, Omega ~ Last)
----------------------------------------------------------------------------------------------------*/

.alpha {
  margin-right: 0;
}

.omega {
  margin-left: 0;
}

By redefining the margin at the .grid-x selector, it's easier to understand. Should have been this way from the start.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.