From a content editor's POV, it would be useful if the images for each term could be uploaded as the term is being created, as opposed to having to go to a separate tab after the fact to do this.

In 4.6 this was impossible without hacking, but with hook_form_alter it seems like this might be the way to go.

I'll try and roll a patch one of these days...

CommentFileSizeAuthor
#4 mw_22.patch9.51 KBmoshe weitzman
#2 mw_21.patch9.47 KBmoshe weitzman

Comments

csevb10’s picture

I agree with that idea, and like you will roll a patch when/if time avails itself.
I think the same idea is being passed around over here: http://drupal.org/node/126057

moshe weitzman’s picture

Assigned: webchick » moshe weitzman
Status: Active » Needs review
StatusFileSize
new9.47 KB

here is the patch that puts image upload on term form. i maintained an overview form which is handy for sites that only have a hundred terms or less. a little other cleanup too.

i believe jeremy is travelling so i will commit this if no reply in while. others are welcome to test.

jeremy’s picture

Status: Needs review » Needs work

Looks great, I much prefer that you can now upload images as you are creating/editing taxonomy terms. I've been meaning to implement that for ages, but never got around to it. I'm very happy to see this module get some much needed love.

One small issue is that it seems the settings page is now orphaned -- I don't see a way to get to it, so with this patch applied you can't set up taxonomy_image recursion, modify the file path, or do any image resizing.

It also seems that file uploads are being named "category_pictures_#" instead of the name of the file uploaded -- but I doubt that's related to your patch. ("category_pictures/" should be a directory created within which the category pictures are uploaded to.)

moshe weitzman’s picture

Status: Needs work » Needs review
StatusFileSize
new9.51 KB

i fixed the settings page and cleaned up the term form alter a bit. i might have fixed the path issue since i can't reproduce it.

moshe weitzman’s picture

anyone out there ....?

jeremy’s picture

Status: Needs review » Needs work

I applied the patch, but I'm still not finding the menu for configuring the taxonomy_image module. I could be doing something wrong, it's very late and I've had a long day. If I manually enter the path "?q=admin/settings/taxonomy_image" I see "array()" output.

The path problem still happens for me, but again I don't think that's related to your patch.

If you can fix the menu issue that would be great. Or if you don't have time for it, please commit this patch as I still think the ability to add images directly with taxonomy terms is excellent, and then I'll look into these other issues when I get some time. I'm going to be offline for the next week or three, so I'll not be following up on this soon.

nancydru’s picture

This is a little bit farther down my ToDo list, but I will get to it. I do see a lot of collisions with the current code, so I may have to through it manually.

nancydru’s picture

Title: Add the ability to upload an image on the term form » Integrate with Taxonomy UI.
Component: Code » User interface

Moshe, I don't suppose you could re-roll this based on the current code, please? I have started trying to manually aply the changes, but this is a very slow process.

nancydru’s picture

Status: Needs work » Fixed

Never mind, Moshe, I got it working. Thanks for the patch. You didn't handle op=delete, but now it does.

Fix committed.

nancydru’s picture

Status: Fixed » Closed (fixed)