The attached patch adds the tag as a configurable option, so that these headers can be output with h1, h2, etc instead of a div.

CommentFileSizeAuthor
panels_header.configure_tags.patch2.24 KBjhedstrom

Comments

dww’s picture

dww
we/he/they
commented

This is a theme function. If you wanted h2 vs. div vs. whatever, why not just modify the theme function on your site? Are you saying you want to potentially change the tag for each individual header instance? That seems like overkill. Just trying to understand why I should "bloat" this module with this feature. I'm trying to keep this as painfully simple as possible so it's easy to port and doesn't bog down with extra overhead for stuff most people don't need.

Thanks!
-Derek

dww’s picture

dww
we/he/they
commented
Status: Needs review » Postponed (maintainer needs more info)

Still awaiting an answer on this...

Thanks,
-Derek

jason.bell’s picture

jason.bell commented

I was about to start in on the same patch and found this. This type of configurable option would be very helpful since the pane header may not always carry the same hierarchy within a given design. The other thought I had was adding a css class input for providing custom classes to a header pane. This would be in line with some of the new features in Views 3 which allows configuring tags via the interface.

I understand the desire to keep this module simple, but would find more use with it if adding a custom header could have more styling hooks. Overwriting the theme function isn't an option for all site builders or content editors.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

@dww sorry I didn't see your initial response until now. I think @jason.bell fairly well summarizes why this is nice to be able to do outside of the theme layer. In addition to Views 3, semantic CCK and semantic views offer similar functionality.