In some files, there are php short tags being used <? ?> which might result in a wrong output if php is not configured to accept short tags.

Drupal coding standards:
http://drupal.org/coding-standards#phptags

From the PHP Manual:
Using short tags should be avoided when developing applications or libraries that are meant for redistribution, or deployment on PHP servers which are not under your control, because short tags may not be supported on the target server. For portable, redistributable code, be sure not to use short tags.

Comments

eugenmayer’s picture

eugenmayer commented
Priority: Critical » Minor

Well, you are right. I will fix this, but this is surely not critical at all. If someone really runs into that (at all), its like 5 minutes work of providing a fix (patch).

Nevertheless i will remove those shortags when i have time ofc.

sign’s picture

sign commented

to be honest, I think it is critical. but I'll leave it to you ;)
Imagine a newbie, that doesn't know anything about the server config, etc...
It will break the drupal installation and there is no way to go back, they will just see chunks of code on their page.
And the only solution is to delete the module from filesystem or fix the code

eugenmayer’s picture

eugenmayer commented

sign,

what newbie would install that module? This aint a newbie task at all...this is not a "mass module". I would rather even downgrade this one as a feature request..but actually iam not eager to step on your toes :)

I will look after it

eugenmayer’s picture

eugenmayer commented
Status: Active » Fixed

fixed in rc2

eugenmayer’s picture

eugenmayer commented
Status: Fixed » Closed (fixed)
sign’s picture

sign commented

Cool,
You never know what newbies are up to :)

Thanks for a very quick turn around. Well done!

Btw it is a good practice to keep issues Open (eg. fixed, etc...), they will be closed automaticaly after 14 days of inactivity. It's good when someone experiences the same problem, they can still see it for some time in the issue queue, although open, but fixed.