How to change content affiliation for 1000+ nodes

Domain Content already lets you do 50 at a time.

The D6 version is closed to new feature requests. A small helper module would probably achieve this integration.

Here's a small pseudo-patch that I might consider. This is in Domain Content module, and should open its node operations to other modules.

/**
 * Implement hook_node_operations()
 */
function domain_content_node_operations() {
  // Only privileged users can perform this operation.
  if (user_access('set domain access')) {
    $operations = array(
      'domain' => array(
      'label' => t('Change affiliate publishing options'),
      'callback' => 'domain_content_node_operations_access',
      )
    );
    return $operations;
  }
}

/admin/content/node2 ?? What module sets that path?

Note that you still need the 'set domain access' permission for the form element to appear.

Oh, that patch just adds the operation. You would still need the form selection element, and it is not clear to me how to add that to any form.

And this is why we already provide this feature in Domain Content.

Yes, but how? Is that form (from VBO) consistently named?

Just having the operation doesn't do anything.

I can't make VBO work. I get this stupid error when trying to add the new operation.

Even so, give this a shot. Apply from the domain root dir.

Last patch forgot to set option properly.

Try the second patch, in #10.

I think your point in #15 is correct. In our normal usage, that callback is all we need. In VBO cases, we probably need a different callback.

Of course, I can't get VBO to _work_ with Views 6.x.2.8...

Firefox (3.5 on OS X). It's a form element thing. It says to edit the fields, but no fields are shown.

Maybe... Can you try?

Tagging.

I'm getting the following error with the patch in #28:
Parameter 1 to domain_content_node_operations_access_submit() expected to be a reference, value given in views_bulk_operations\views_bulk_operations.module on line 901.

Also I cannot make any changes to affiliates using VBO.

I have 6.x-1.9 as well.
The line 901 in VBO is

return call_user_func($action_submit, $form, $form_values);

while domain_content_node_operations_access_submit uses &$form and &$form_values.

Patch against DRUPAL-6--2 attached.

domain_content_node_operations_access_submit was using reference while it needs to use value.

Which PHP version are you running? Mine is 5.3.1

Let's be sure that none of this breaks Domain Content. I also wonder if we can expose this to VBO directly in domain.module, so people wouldn't need to use Domain Content unless they wanted to.

ack... broken again in 6.24 why was this not added to HEAD?

DID YOU REVIEW THE PATCH?

NO. YOU DIDN'T.

So you have no grounds to complain. And you're being offensive.

Read the thread. The two maintainers cannot make VBO work properly, so we cannot commit the patch, because we can't even verify that it works.

And it's not broken "again". The functionality does not currently exist. Domain Content _predates_ VBO.

Either help or leave.

And the questions in #40?

The function domain_content_node_operations_access_submit() is just plain wrong. It processes when the confirm form is loaded, not when it is submitted.

Here's the current patch against 6--2, which fixes everything (?) except the error in domain_content_node_operations_access_submit().

Works with Domain Content, the normal Node admin form, and VBO. Though the VBO confirm operation is broken.

I would also greatly prefer to _remove_ the broken intermediate step in the VBO process and simply add the DA form elements directly to the selection form, as it's done in the other two cases.

And why are the arguments wrong? domain_content_node_operations_access_submit($form, $form_values)? That's D5 syntax.

This was a very sloppy patch.

domain_content_node_operations_access_submit needs to be removed and made to work with domain_content_update_nodes(). The duplicate code is painful.

wow, hit a nerve here. Didn't mean to be offensive. The patch above DID work for me in 6.21 without any trouble. I was not being accusatory, merely asking why it wasn't added in. As I said, it does work for me in 6.21, just not in 6.24. I'm sorry for coming off badly.

Well, the patch has known bugs in it, and is not ready for production. The patch in #48 should apply to 6.x.2.4, so give it a try.

Watch what happens, however, if you hit 'Cancel' on a VBO operation. The changes still get saved. That's a bad oversight.

Part of my frustration here is that 6.x is essentially closed to new features. I'm considering an exception here, and doing extra work. So hollow complaints just don't cut it.

re #51 - most developers create patches in issue_number + module_name + branch_version format to keep track of the patches - which results in filename like 710712-domain-DRUPAL-6--2.patch. This way it's easy to find all module or version specific patches.

Or at least that's how I've understood/used it;)

I'd still like to see the code duplication between domain_content_node_operations_access_submit_process and domain_content_update_nodes removed.

I also just noticed that this method will not work properly IFF another module uses hook_domainrecords(). We are deliberately writing to the {node_access} table, and in some cases, that will not be desired. We may need to invoke node_access_needs_rebuild() if hook_domainrecords() is present.

1. No. I'm not putting redundant code in HEAD. You want the feature? Write the code better.

2. We have to refactor domain_content_update_nodes() to incorporate hook_domainrecords(). That's part of the work to be done. That _could_ however, be split to a new issue.

3. No. It's not ready. So I didn't test it.

6.x is bugfix only. This is not a bug. It's a feature. And, no, I didn't write domain_content_node_operations_access_submit_process().

I'm busy with the D7 port.

Split off #756162: Domain Content ignores hook_domainrecords().

Here's a better patch.

I _still_ don't like the VBO workflow, but am willing to let that go.

@fizk I need you to _document_ the VBO functions in this code. It's a black box, and I don't like those. In particular, I don't know what domain_content_node_operations_process_submit is doing with the 'step' value.

When testing, be aware that there are 3 separate use cases for this functionality. Your last patch broke two of them because it was entirely focused on VBO.

This will also be easy to integrate with #756162: Domain Content ignores hook_domainrecords() when ready.

admin/build/content -- the normal batch editing screen. Triggered a form submit when no values were passed.

Same for admin/domain/content/0.

As I said, the cases you discuss are only VBO operations. hook_node_operations() is also fired by core and by Domain Content. Note the argument changes required in function domain_content_node_operations_process() to make this work.

This patch is _not_ VBO-specific. It adds VBO support and extends generic node_operations.

Nope. It's a core hook. One that we used to implement only on the Domain Content pages. Now we're opening it up to all three.

See http://api.drupal.org/api/function/hook_node_operations

This is why I keep saying that I don't like how VBO handles the form. It's different from the other two uses.

The D6 version of DA is bugfix only, so if we're taking any approach other than this, it needs to be addressed in a separate module.

I would be ok with removing the VBO portions of this patch, committing the other changes, and letting VBO support happen somewhere else.

There is an existing module for this functionality: http://drupal.org/project/domain_actions

The purpose of the core DA suite is to support Drupal core. VBO is a special case that I do not feel compelled to support.

I was a little surprised to see this closed. Note the changes here, if looking at how actions might work.

#757746: please add different way for "Change affiliate publishing options"

I committed this version of the patch to 6.x.2 and HEAD.

Accidentally left in some VBO-specific cruft.

It doesn't "fix" anything. There was never a bug. Domain Content just doesn't support VBO.

The code refactor makes it easier for other modules to abstract some of the functions for use. See domain_content_add_form_widget() and domain_content_update_nodes() specifically.

Any actions should leverage these functions.

How to do this with Drupal 7. VBO does not have.
Thanks

Domain Content can still do this.

@ agentrickard
Yes, but that page can not fill by all field.
I have a solution for this issue:
- Step 1. Use VBO, can use any fill condition, change all nodes you want to "Stick"
- Step 2. Use admin/content use stick filter, change all node you have to domain you want
- Step 3. Use VBO, use stick filter, change back to Un-Stick

Look at: https://www.drupal.org/project/domain_vbo

Drupal 7 in End of Life and no longer supported. We encourage you to upgrade to a supported version of Drupal. For more information, see https://www.drupal.org/upgrade.

	Thank you for your contribution! Your continued support of this project makes other volunteer contributions more sustainable.
There are multiple ways to show appreciation for the work contributed to this project, including: Triaging issues and adding more context to existing issues. Writing documentation or patches for this project.