Since site migrations may break sites in ways that aegir could not detect, it would be important to notify the user that an upgrade happened so the right people can test the site.

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

Let me know what you think of my feature branch . I put this in the frontend so that we could take advantage of drupal_mail (which we can't in the backend unless we do a full drush bootstrap of the site, and then we need to include core install files to use st() and so on..). I also make it optional, by adding a config option for Migrate in the Feature admin area.

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

Great work! I think there a few things that look odd in there, but it's otherwise a great push forward.

This is weird:

+        $message['body'] = t($mail['body'], $params['variables']);

esp. since $mail['body'] is initialized with t() call in the first place. I think the mail body should be a template the same way we have templates for apache config files. The subject would then be hardcoded (although you could still change it through t() hacks). Even then, since we use drupal_mail, i'm not even sure we need templates at all, just throw the mail body straight in the code and let hooks override that.

Otherwise, I don't know where I can get your remote anymore... There's no git:// link on git.mig5.net. Besides, feel free to push your feature branches on the main server..

Anonymous’s picture

Anonymous (not verified) commented

Yeah much of that stuff was blindly copied from install_send_welcome_mail() in Provision :) I'll try and clean it up.

thanks

steven jones’s picture

steven jones commented
Status: Needs work » Fixed

So...the best way to do this is to integrate with a pre-existing notifications framework, which I've done here:
http://drupal.org/project/hosting_notifications/

I currently send notifications of all migrations to my iPhone :)

This could do with some love, but the module is there!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.