Hi there,

First off loving the module, simple to use and does what it says on the tin (the best kind of module)

however one thing is missing which if added would make this exactly what all my non technical and probably other peoples non technical clients are after.

Now im not sure if this is possible but could you make the [video:url] tag actually output the video thumbnail in the WYSIWYG as opposed to the code so that we could re-edit the url by clicking said thumbnail and then clicking the TinyMCE button thats been added recently, its so simple to get around this by just changing the URL in the code i know, but im sure youre not surprised when i tell you the moment one of my clients see a bit of code in any shape or form they run for the hills! so this would be a holy grail of non technical video adding using a WYSIWYG.

Thanks for your time.

regards,

Mike

Comments

anon’s picture

StatusFileSize
new7.77 KB

This patch converts [video:url] to "static placeholders" almost like Media does.

This means when the editor is loaded and [video:urls] is found in the content, this will replace [video:url] with a "box", but not save it like that.

Width and height for the box is specifyed by the user input, OR by default options.

This patch needs #741832: dailymotion regexp match to much to work 100%. (if you using one or more dailymotion videos on your site).

anon’s picture

Status: Active » Needs review
blackdog’s picture

Status: Needs review » Needs work

Good stuff!

I can't get it to work though.. I found some hardcoded paths that I changed, and copied the code from src to the included file, but still no placeholders. Will try to update TinyMCE to see if that's the issue. What versions are you using?

anon’s picture

StatusFileSize
new8.09 KB

TinyMCE 3.2.1.1

Oh sorry about that hardcoded url.

Here is the patch again with that url fixed.
I Also changed the way define the "file" url in the regsiter commands method.

EDIT:
This still needs work..

anon’s picture

Status: Needs work » Needs review
StatusFileSize
new8.94 KB

Added: When you insert a video from the popup, this placeholder will be inserted into the editor.

anon’s picture

StatusFileSize
new8.94 KB

This is now tested and should work for new nodes and when editong nodes.

blackdog’s picture

Status: Needs review » Needs work
+++ video_filter.module	17 Mar 2010 17:46:20 -0000
@@ -266,6 +266,40 @@
+    $node = node_load(arg(1));

This hook gets called on non-node pages too.

+++ video_filter.module	17 Mar 2010 17:46:20 -0000
@@ -266,6 +266,40 @@
+      'css' => drupal_get_path('module', 'video_filter') .'/wysiwyg/tinymce/video_filter.css',

This has moved to the root folder.

+++ video_filter.module	17 Mar 2010 17:46:20 -0000
@@ -276,6 +310,7 @@
+            'css' => drupal_get_path('module', 'video_filter') . '/wysiwyg/tinymce/video_filter.css',

Path again.

+++ wysiwyg/tinymce/editor_plugin_src.js	17 Mar 2010 17:45:08 -0000
@@ -1,10 +1,22 @@
+				return /^(videoFitler)$/.test(n.className);

What's videoFitler? ;)

+++ wysiwyg/tinymce/video_filter.css	17 Mar 2010 07:12:08 -0000
@@ -12,4 +12,12 @@
+img.videoFitler {

Fitler?

Also, take a moment to check the code standards.

Powered by Dreditor.

anon’s picture

Ok, fixed almost all those bugs, but there is one I cant figure out how to do.

Its the first with $node = node_load(arg(1));

How can I get the format here??? any ideas?

anon’s picture

and also, Whats not following the code standards?

blackdog’s picture

How can I get the format here??? any ideas?

We only need these settings when we're on node/NID/edit AND node/add/content_type.

So we can check if arg(0) == node && arg(2) == edit, but that won't work for new nodes. Not sure how to handle that.

The code standards stuff is mostly white space trailing and some tabs.

anon’s picture

Cant see why just only on node/NID/edit AND node/add/content_type.

what about blocks?

gausarts’s picture

Subscribing. Thanks

minnur’s picture

Version: 6.x-2.7 » 8.x-1.x-dev
Assigned: Unassigned » minnur
Issue summary: View changes
Status: Needs work » Needs review

This is interesting idea. I will look into this more.

minnur’s picture

minnur’s picture

Assigned: minnur » Unassigned
Category: Feature request » Task
Priority: Minor » Major

I spent some time trying to implement this but no success. The idea is to take token and replace it with a thumbnail provided by codec/provider. If no thumbnail method provided fallback to a base class method that returns default image.
On double click CKEditor would bring the dialog form with the values from a [video:] tag.

I think this would be a huge improvement to the module.

Thanks!

This is top priority in my list and any help will be appreciated!

proofoftom’s picture

Status: Needs review » Needs work
damienmckenna’s picture

Just to be clear, I don't think "url" is the appropriate token string to indicate a thumbnail, I think "thumbnail" or "thumb" would be better.