Hi there,
First off loving the module, simple to use and does what it says on the tin (the best kind of module)
however one thing is missing which if added would make this exactly what all my non technical and probably other peoples non technical clients are after.
Now im not sure if this is possible but could you make the [video:url] tag actually output the video thumbnail in the WYSIWYG as opposed to the code so that we could re-edit the url by clicking said thumbnail and then clicking the TinyMCE button thats been added recently, its so simple to get around this by just changing the URL in the code i know, but im sure youre not surprised when i tell you the moment one of my clients see a bit of code in any shape or form they run for the hills! so this would be a holy grail of non technical video adding using a WYSIWYG.
Thanks for your time.
regards,
Mike
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | video_filter_711260_4.patch | 8.94 KB | anon |
| #5 | video_filter_711260_3.patch | 8.94 KB | anon |
| #4 | video_filter_711260.patch | 8.09 KB | anon |
| #1 | video_filter_711260.patch | 7.77 KB | anon |
Comments
Comment #1
anonThis patch converts [video:url] to "static placeholders" almost like Media does.
This means when the editor is loaded and [video:urls] is found in the content, this will replace [video:url] with a "box", but not save it like that.
Width and height for the box is specifyed by the user input, OR by default options.
This patch needs #741832: dailymotion regexp match to much to work 100%. (if you using one or more dailymotion videos on your site).
Comment #2
anonComment #3
blackdog commentedGood stuff!
I can't get it to work though.. I found some hardcoded paths that I changed, and copied the code from src to the included file, but still no placeholders. Will try to update TinyMCE to see if that's the issue. What versions are you using?
Comment #4
anonTinyMCE 3.2.1.1
Oh sorry about that hardcoded url.
Here is the patch again with that url fixed.
I Also changed the way define the "file" url in the regsiter commands method.
EDIT:
This still needs work..
Comment #5
anonAdded: When you insert a video from the popup, this placeholder will be inserted into the editor.
Comment #6
anonThis is now tested and should work for new nodes and when editong nodes.
Comment #7
blackdog commentedThis hook gets called on non-node pages too.
This has moved to the root folder.
Path again.
What's videoFitler? ;)
Fitler?
Also, take a moment to check the code standards.
Powered by Dreditor.
Comment #8
anonOk, fixed almost all those bugs, but there is one I cant figure out how to do.
Its the first with
$node = node_load(arg(1));How can I get the format here??? any ideas?
Comment #9
anonand also, Whats not following the code standards?
Comment #10
blackdog commentedWe only need these settings when we're on node/NID/edit AND node/add/content_type.
So we can check if arg(0) == node && arg(2) == edit, but that won't work for new nodes. Not sure how to handle that.
The code standards stuff is mostly white space trailing and some tabs.
Comment #11
anonCant see why just only on node/NID/edit AND node/add/content_type.
what about blocks?
Comment #12
gausarts commentedSubscribing. Thanks
Comment #13
minnur commentedThis is interesting idea. I will look into this more.
Comment #14
minnur commentedComment #15
minnur commentedI spent some time trying to implement this but no success. The idea is to take token and replace it with a thumbnail provided by codec/provider. If no thumbnail method provided fallback to a base class method that returns default image.
On double click CKEditor would bring the dialog form with the values from a [video:] tag.
I think this would be a huge improvement to the module.
Thanks!
This is top priority in my list and any help will be appreciated!
Comment #16
proofoftom commentedComment #17
damienmckennaJust to be clear, I don't think "url" is the appropriate token string to indicate a thumbnail, I think "thumbnail" or "thumb" would be better.