Hi. I've set up nodecomments (content type: comment) as default comments for forum posts with display mode: threaded expanded and sorted by oldest firs (freshest comment is on the bottom). Everything works and is displayed as expected but as soon as I edit any of the comments, the edited comment gets moved to the top of the list. If the edited comment is threaded (a comment to a comment) it loses it's threading and is moved to the top of the list.

I also tested this on my sandbox site with nodecomments set up (content type: comment) for the story content type and displayed the same way. The same stuff happens there.

I've also tried fiddling with the nodecomment views styles, relationships and sort criteria but none of that seems to help the least bit, even though I cleared the caches every time I made changes.

Any thoughts?

CommentFileSizeAuthor
#7 nodecomment_711282_2.patch2.25 KBcrea
#4 nodecomment_711282.patch1.18 KBcrea

Comments

einkahumor’s picture

einkahumor commented

After some comments have been edited on a thread (and the threading thus mixed up), new comments aren't added to the right places in the tread, even if they aren't replies to comments.

crea’s picture

crea commented

Can anyone else confirm this ?

crea’s picture

crea commented

Yep, there's a problem with editing.

crea’s picture

crea commented
Status: Active » Needs review
StatusFileSize
new nodecomment_711282.patch1.18 KB

Threading is broken on editing because it's inserted into DB as numeric rather than string.

Narretz’s picture

Narretz commented

I made some quick tests. After applying the patch, comments still get mixed up; but replys to mixed up comments get inserted correctly, but will ofc break when they are edited.

einkahumor’s picture

einkahumor commented
Status: Needs review » Needs work

Glad to see some improvement on this. Confirming what is said in #5 and updating status.

crea’s picture

crea commented
Status: Needs work » Needs review
StatusFileSize
new nodecomment_711282_2.patch2.25 KB

There was also a problem of thread recalculation.

crea’s picture

crea commented

We could also follow comment module in this part: comment module does not update thread column at all. But I think updating it gives some flexibility e.g. for future usecases such as thread/comment moderation, moving etc.

einkahumor’s picture

einkahumor commented

Seems to be working quite well. Thanks!

Narretz’s picture

Narretz commented
Status: Needs review » Reviewed & tested by the community

confirmed. Editing works.

changed status to reviewed & tested (I don't think there will be many more reviews, and the tests are pretty straightforward)

crea’s picture

crea commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.